Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: [committed] [gdb/contrib] Remove superfluous .alt file after dwz invocation in cc-with-tweaks.sh
Date: Tue, 23 Apr 2019 13:42:00 -0000	[thread overview]
Message-ID: <408e32f8-0414-7f43-715c-c47077cb9ba2@suse.de> (raw)
In-Reply-To: <20190411102627.GA1116@delia>

Committed as obvious.

Thanks,
- Tom

On 11-04-19 12:26, Tom de Vries wrote:
> Hi,
> 
> The -m option of cc-with-tweaks.sh sets want_multi to true, invoking dwz like
> this:
> ...
> elif [ "$want_multi" = true ]; then
>     cp $output_file ${output_file}.alt
>     $DWZ -m ${output_file}.dwz "$output_file" ${output_file}.alt \
>         > /dev/null 2>&1
> fi
> ...
> 
> The problem that is being solved here, is that we want to test dwz in
> multifile mode, which requires more than one input file, while we only have
> (at the scope of cc-with-tweaks.sh) one executable.  We handle this by copying
> the executable and offering this as a second input (and using a copy has the
> additional benefit that it maximally enables dwz transformation).
> 
> However, after the dwz invocation, the copy is no longer used, and the
> presence of the file actually causes a test regression:
> ...
> FAIL: gdb.base/jit-so.exp: test jit-reader-load filename completion
> ...
> 
> Fix this by removing the superflous copy after dwz invocation.
> 
> Tested on x86_64-linux.
> 
> OK for trunk?
> 
> Thanks,
> - Tom
> 
> [gdb/contrib] Remove superfluous .alt file after dwz invocation in cc-with-tweaks.sh
> 
> gdb/ChangeLog:
> 
> 2019-04-11  Tom de Vries  <tdevries@suse.de>
> 
> 	PR gdb/24438
> 	* contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
> 	invocation.
> 
> ---
>  gdb/contrib/cc-with-tweaks.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gdb/contrib/cc-with-tweaks.sh b/gdb/contrib/cc-with-tweaks.sh
> index f6bfa16565..33c6322138 100755
> --- a/gdb/contrib/cc-with-tweaks.sh
> +++ b/gdb/contrib/cc-with-tweaks.sh
> @@ -180,6 +180,7 @@ if [ "$want_dwz" = true ]; then
>  elif [ "$want_multi" = true ]; then
>      cp $output_file ${output_file}.alt
>      $DWZ -m ${output_file}.dwz "$output_file" ${output_file}.alt > /dev/null 2>&1
> +    rm -f ${output_file}.alt
>  fi
>  
>  if [ "$want_dwp" = true ]; then
> 


  reply	other threads:[~2019-04-23 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 10:26 [PATCH] " Tom de Vries
2019-04-23 13:42 ` Tom de Vries [this message]
2019-04-24 19:23 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=408e32f8-0414-7f43-715c-c47077cb9ba2@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox