Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfa] hppa stub unwinder
Date: Sat, 24 Apr 2004 00:03:00 -0000	[thread overview]
Message-ID: <40892745.8010807@gnu.org> (raw)
In-Reply-To: <20040423040108.GD17279@tausq.org>

> Thanks for Andrew's hint, here's a stub unwinder for hppa. Helps us out
> in the testsuites quite a bit. okay to checkin?

(FYI, Ulrich came up with the theory.  Yes it works well -> keeps each 
unwinder focused and simple (far cry from the old way :-)).

It's ok as is (with coding tweaks).  One option, though is to instead of:

> -  frame_unwind_append_sniffer (gdbarch, hppa_frame_unwind_sniffer);
> -  frame_base_append_sniffer (gdbarch, hppa_frame_base_sniffer);
> -
> -  set_gdbarch_pseudo_register_read (gdbarch, hppa_pseudo_register_read);
>  
>    /* Hook in ABI-specific overrides, if they have been registered.  */
>    gdbarch_init_osabi (info, gdbarch);
> +
> +  /* Hook in the default unwinders.  Do this last in case the osabi
> +     wants to add additional unwinders.  */
> +  frame_unwind_append_sniffer (gdbarch, hppa_stub_unwind_sniffer);
> +  frame_unwind_append_sniffer (gdbarch, hppa_frame_unwind_sniffer);
> +  frame_base_append_sniffer (gdbarch, hppa_frame_base_sniffer);
> +  frame_base_set_default (gdbarch, &hppa_frame_base);

use frame_unwind_prepend_unwinder() which addresses the ordering 
problem.  If you want to convert things, it's pre-approved.

> randolph
> 
> 
> 2004-04-22  Randolph Chung  <tausq@debian.org>
> 
> 	* hppa-tdep.c (hppa_stub_unwind_cache, hppa_stub_frame_unwind_cache)
> 	(hppa_stub_frame_this_id, hppa_stub_frame_prev_register)
> 	(hppa_stub_frame_unwind, hppa_stub_unwind_sniffer): New stub unwinder
> 	for handling stackless frames.
> 	(hppa_gdbarch_init): Link in hppa_stub_unwind_sniffer. Rearrange the
> 	order of unwinder registration vs init_osabi so that additional
> 	osabi-specific unwinders can be hooked in.

Andrew



  parent reply	other threads:[~2004-04-24  0:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-23  4:00 Randolph Chung
2004-04-23  4:30 ` Daniel Jacobowitz
2004-04-24  0:03 ` Andrew Cagney [this message]
2004-04-24  6:17   ` Randolph Chung
2004-04-24  6:47   ` Randolph Chung
2004-04-28 15:49     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40892745.8010807@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox