From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-32523-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 8916 invoked by alias); 22 Apr 2004 19:27:08 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 8908 invoked from network); 22 Apr 2004 19:27:07 -0000
Received: from unknown (HELO localhost.redhat.com) (24.157.170.238)
  by sources.redhat.com with SMTP; 22 Apr 2004 19:27:07 -0000
Received: from gnu.org (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 447EA2B9D; Thu, 22 Apr 2004 15:26:49 -0400 (EDT)
Message-ID: <40881C79.6030205@gnu.org>
Date: Thu, 22 Apr 2004 19:27:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217
MIME-Version: 1.0
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] Fix unwind handling for hppa
References: <20040417080536.GB17842@tausq.org> <20040417163525.GA3521@nevyn.them.org> <40855B13.7060706@gnu.org> <20040421151820.GI17842@tausq.org> <4086ED46.2050809@gnu.org> <20040422000655.GL17842@tausq.org> <40871165.4070203@gnu.org> <20040422030116.GO17842@tausq.org>
In-Reply-To: <20040422030116.GO17842@tausq.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-04/txt/msg00538.txt.bz2

>>In that only call the HP function when the generic one fails.  However, 
>>> first can you investigate the details?  This sort of thing needs to be 
>>> commented.
> 
> 
> one more note about this:
> 
> skip_prologue_using_sal() sometimes returns a pc that is past the end of
> a function. after_prologue() in hppa-tdep.c checks for this explicitly
> and returns 0 in this case so that we can fall back to code reading.
> this can be observed e.g. with gdb.base/break.exp with the
> "breakpoint small function, optimized file" test. Is this expected? or
> is it a bug in skip_prologue_using_sal()?

Ok, can you post the revised change (with comments explaining all this)?

Andrew