Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Roland McGrath <roland@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [KLUDGE PATCH] Linux vsyscall DSO support
Date: Thu, 22 Apr 2004 00:18:00 -0000	[thread overview]
Message-ID: <40870F4A.4010009@gnu.org> (raw)
In-Reply-To: <200404082150.i38LoEcx010967@magilla.sf.frob.com>

>>> Last time this was discussed the observer was identified as the correct 
>>> mechanim for hooking this in.  That's why I'm currently overhauling that 
>>> code.
> 
> 
> Ok.  I forget many things, but I think this is news to me.

I remember sending an explicit e-mail, I suspect you didn't see it as 
your mailing address got trimmed part way through the thread :-(

>  I hadn't seen
> the "observer" code before; I now see it's a simple facility for running a
> list multiple hooks previously registered, so this is today's preferred
> form of adding a new hook.  Two questions remain for me:
> 
> What is the new hook or hooks you plan to add?  i.e., will it be a single
> "look freshly at address space" hook, or separate hooks for "attached",
> "exec'd", "opened core", etc?  It matters little, unless we anticipate
> future different situations that would also qualify as "look freshly at
> address space" situations but aren't one of the three I listed.

I think there should be a something like a "new_inferior" event that 
incorporates "run", "attach", and "corefile".  As we've recently 
discovered, "run" is just a slight simplification of attach.  (Because 
of some screwieness in how the target vector is [isn't] designed, a 
number of files will need to have the call added - that can be handled 
as identified).

> Where is the right place to install our observer?  My inclination is to add
> linux-tdep.c to all the Linux targets as my strawman patch does, and have
> an _initialize_linux_tdep function that registers the observers.  Is that
> what you are thinking as well?

Guess so.  The decsion to load one of these shlibs is really based 
solely on the presence of that AT_xxxx auxv entry and the observer gets 
to check that.

Andrew



      reply	other threads:[~2004-04-22  0:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-08 21:09 Roland McGrath
2004-04-08 21:30 ` Andrew Cagney
2004-04-08 22:13   ` Roland McGrath
2004-04-22  0:18     ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40870F4A.4010009@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox