From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26760 invoked by alias); 8 Apr 2004 22:40:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26753 invoked from network); 8 Apr 2004 22:40:28 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 8 Apr 2004 22:40:28 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i38MeSME017967 for ; Thu, 8 Apr 2004 18:40:28 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i38MeSj03646; Thu, 8 Apr 2004 18:40:28 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 94D7B2B9C; Thu, 8 Apr 2004 18:40:25 -0400 (EDT) Message-ID: <4075D4D9.7000104@gnu.org> Date: Thu, 08 Apr 2004 22:40:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Generate observer.[hc] References: <4075BF8E.9080706@gnu.org> <20040408222914.GA32726@nevyn.them.org> In-Reply-To: <20040408222914.GA32726@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-04/txt/msg00204.txt.bz2 > On Thu, Apr 08, 2004 at 05:09:34PM -0400, Andrew Cagney wrote: > >>> Hello, >>> >>> The attached adds the script observer.sh that can be used to generate: >>> observer.h >>> observer.ch (#included by observer.c) >>> aat build time using doc/observer.texi as the input. >>> >>> While this is more ambitious than gdbarch.* (which are explicitly >>> generated and then committed to CVS) I suspect it is prefered. >>> >>> Comments? >>> >>> Once this is in I can add a few observers, and start deleting all those >>> hooks and events. > > > I like it, and the patch looks fine to me. My only complaint is that I > don't much like the .ch suffix. But then, using .c is probably pretty > confusing too, so I don't have a better idea - I won't complain. So far I've been through .hh .cc .hc .ch .... >>> -@deftypefun extern struct observer *observer_attach_normal_stop (observer_normal_stop_ftype *@var{f}) > > > Also, my instinct when reading this manual would be to just remove > these obsolete "extern"s. Which would break the script, since it would > try to generate an event for observer_detach_@var{event}. So I think > that either that should be fixed or there should be a comment somewhere > to leave them in. Oops, thats the wrong example, try: +@deftypefun void normal_stop (struct bpstats *@var{bs}) (yes the externs can go) Andrew