From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16577 invoked by alias); 6 Apr 2004 23:33:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16547 invoked from network); 6 Apr 2004 23:33:39 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 6 Apr 2004 23:33:39 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i36NXcWD027513 for ; Tue, 6 Apr 2004 19:33:38 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i36NXcj32197; Tue, 6 Apr 2004 19:33:38 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B31582B9C; Tue, 6 Apr 2004 19:33:40 -0400 (EDT) Message-ID: <40733E54.6050203@gnu.org> Date: Tue, 06 Apr 2004 23:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Andrew Cagney Cc: Daniel Jacobowitz , Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Use frame_type for sigtramp test in infrun.c References: <200403292338.BAA16799@faui1d.informatik.uni-erlangen.de> <406DD226.1080104@gnu.org> <20040403000855.GF871@gnat.com> <406E0CEA.7040906@gnu.org> <20040406014818.GN871@gnat.com> <20040406162150.GT871@gnat.com> <4072ED55.6010007@gnu.org> <20040406175411.GA19407@nevyn.them.org> <4072F2DB.4070409@gnu.org> In-Reply-To: <4072F2DB.4070409@gnu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-04/txt/msg00158.txt.bz2 >>> based on other discussion, I suspect the test will need to be: >>> >>>> >>>> if (frame_id_inner (this_frame_id, step_frame_id) >>>> || frame_id_eq (....)) >>>> >>>> the former is to handle a signal delivery that resumed the inferior at the signal handler and not the signal trampoline. >> >> >> >> Won't anywhere you do that frame_id_inner test add another breakage for >> sigaltstack? > > > Hmm, true. Sigaltstack will break any inner test. Ok (talked this through with jeff). The id_inner test isn't needed. The case of GDB doing a nexti and ending up in a signal handler should have been handled earlier (in time). At the point where the signal first arrives - GDB should have set a breakpoint at the signal return address and then continued the inferior with the signal. Time to turn infrun.c into a state machine :-/ Andrew