Re: [patch/rfc] Use frame_type for sigtramp test in infrun.c

Andrew Cagney
2004-04-29T22:46:10Z

> Andrew,

I've bitten the bullet and committed this. As Joel observes, failures
are revealing latent bugs.

Andrew

>>>> >Just to make sure we're talking about the same patch, attached is the
>>>> >patch I was working on (may need to be updated to the current sources).
>>>> >Is that what you were refering to?
>>
>>>
>>> Yes, but no longer worry about the if(legacy_frame_p) path.
>
>
> I have tested the attached patch on several platforms, and as expected,
> found a few regression here and there. I started analyzing the
> regressions on hp/ux, but this takes time, and I have to do something
> else for a while. A quick glance doesn't say much about the source of
> regressions, but my feeling after the few ones that I analyzed is that
> they are a consequence of a latent bug somewhere else more than a
> problem with the patch itself. The fact that we have no regression on
> both x86-linux and sparc-solaris is also encouraging.
>
> Below is a quick summary of the difference in the testsuite results
> before and after the patch. It sounded like this patch would make your
> life much easier. I'll let you and the other maintainers decide whether
> it's acceptable to include this patch now, as a small step backward to
> allow you to jump farther.