From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24291 invoked by alias); 6 Apr 2004 16:12:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24266 invoked from network); 6 Apr 2004 16:12:31 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 6 Apr 2004 16:12:31 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i36GCV5F031977 for ; Tue, 6 Apr 2004 12:12:31 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i36GCUj18762; Tue, 6 Apr 2004 12:12:30 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7DD2D2B9C; Tue, 6 Apr 2004 12:12:33 -0400 (EDT) Message-ID: <4072D6F1.6030801@gnu.org> Date: Tue, 06 Apr 2004 16:12:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com, Randolph Chung Subject: [commit] Move HP's breakpoint_from_pc to arch vector Content-Type: multipart/mixed; boundary="------------020300030609080704070601" X-SW-Source: 2004-04/txt/msg00143.txt.bz2 This is a multi-part message in MIME format. --------------020300030609080704070601 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 76 FYI, Randolph, its this sort of stuff that needs to be cleaned up. Andrew --------------020300030609080704070601 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1843 Index: ChangeLog 2004-04-06 Andrew Cagney * hppa-tdep.c (hppa_breakpoint_from_pc): Make static. (hppa_gdbarch_init): Set gdbarch_breakpoint_from_pc * config/pa/tm-hppa.h (BREAKPOINT_FROM_PC, BREAKPOINT32): (hppa_breakpoint_from_pc): Delete. Index: hppa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/hppa-tdep.c,v retrieving revision 1.141 diff -u -r1.141 hppa-tdep.c --- hppa-tdep.c 6 Apr 2004 15:41:50 -0000 1.141 +++ hppa-tdep.c 6 Apr 2004 16:07:10 -0000 @@ -658,7 +658,7 @@ return NULL; } -const unsigned char * +static const unsigned char * hppa_breakpoint_from_pc (CORE_ADDR *pc, int *len) { static const unsigned char breakpoint[] = {0x00, 0x01, 0x00, 0x04}; @@ -2726,7 +2726,9 @@ default: internal_error (__FILE__, __LINE__, "bad switch"); } - + + set_gdbarch_breakpoint_from_pc (gdbarch, hppa_breakpoint_from_pc); + /* Frame unwind methods. */ set_gdbarch_unwind_dummy_id (gdbarch, hppa_unwind_dummy_id); set_gdbarch_unwind_pc (gdbarch, hppa_unwind_pc); Index: config/pa/tm-hppa.h =================================================================== RCS file: /cvs/src/src/gdb/config/pa/tm-hppa.h,v retrieving revision 1.68 diff -u -r1.68 tm-hppa.h --- config/pa/tm-hppa.h 3 Apr 2004 17:49:07 -0000 1.68 +++ config/pa/tm-hppa.h 6 Apr 2004 16:07:11 -0000 @@ -39,12 +39,6 @@ struct type; struct inferior_status; -/* Sequence of bytes for breakpoint instruction. */ - -const unsigned char *hppa_breakpoint_from_pc (CORE_ADDR *pcptr, int *lenptr); -#define BREAKPOINT_FROM_PC(PCPTR,LENPTR) hppa_breakpoint_from_pc ((PCPTR), (LENPTR)) -#define BREAKPOINT32 0x10004 - extern int hppa_pc_requires_run_before_use (CORE_ADDR pc); #define PC_REQUIRES_RUN_BEFORE_USE(pc) hppa_pc_requires_run_before_use (pc) --------------020300030609080704070601--