From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13459 invoked by alias); 25 Mar 2004 16:53:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13438 invoked from network); 25 Mar 2004 16:53:05 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 25 Mar 2004 16:53:05 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id DEF8E2B92; Thu, 25 Mar 2004 11:53:05 -0500 (EST) Message-ID: <40630E71.2070807@gnu.org> Date: Thu, 25 Mar 2004 16:53:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Mark Kettenis Cc: bob@brasko.net, rms@gnu.org, gdbheads@gnu.org, gdb-patches@sources.redhat.com Subject: Re: [Gdbheads] Re: Feb's patch resolution rate References: <20040225040059.GB19094@white> <16456.65451.461753.66554@localhost.redhat.com> <20040306155700.GA9439@white> <20040311132508.GA2504@white> <20040323130900.GA17339@white> <4060A523.6010801@gnu.org> <4060ACC8.10209@gnu.org> <20040325041331.GD19966@white> <200403251106.i2PB6sbB000709@elgar.kettenis.dyndns.org> In-Reply-To: <200403251106.i2PB6sbB000709@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-03/txt/msg00621.txt.bz2 > Date: Wed, 24 Mar 2004 23:13:31 -0500 > From: Bob Rossi > > Is quick linear with the size of the patch? > > Defenitely not. As a simple example, a new architecture takes relatively little time to review: - did it get put through gdb_indent.sh (coding ok) - did it get put through gdb_ari.sh (interfaces ok) - anthing obviously garish - can it break core-GDB (no) - is there an assignment Contrast that to a single addition to the architecture vector. Too often the mechanism overlaps existing functionality and hence requires changes far wider than the apparent one line addition. The symbol table is identical. Andrew