Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Signal Trampoline Frames
Date: Thu, 25 Mar 2004 14:42:00 -0000	[thread overview]
Message-ID: <4062EFD2.7000308@gnu.org> (raw)
In-Reply-To: <200403251026.i2PAQXRr000635@elgar.kettenis.dyndns.org>


>     > and uses
>    > the arbitrary number 8 for the number of instructions (which makes it
>    > not quite suitable for SPARC).
> 
>    I'm assuming people will increase it (It's like the arbitrary number 16 
>    for the largest possible size of an instruction).
> 
> OK.  Although you must realize that for SPARC we might need to
> increase it to 80 or so.  Then it makes more sense to check only for a
> small number of key instructions I think.

In that case, don't use it.

BTW, what happens if the inferior is interrupted while executing one of 
those 80 instructions?

>     > The whole thing seems a bit
>    > over-engineered to me :-(.
> 
>    In what way?
> 
>    I wrote it after churn out 4 almost identical signal trampolines - so it 
>    works for one type but not for others.  You also haven't seen my test 
>    cases :-)
> 
> My experience is that there is too much variation for a
> one-size-fits-all trampoline recognition function.  I was under the
> impression that there were only two cases where this could be used.
> Turns out I'm wrong.  I still think we run the risk of
> over-engineering this by adding to much knobs if we try to make it
> work for too many slightly different signal tramps.

Right.

It's a helper for a specific, but fairly common, case.  It works for me 
(and appears to work for daniel :-) but is definitly not a one size fits 
all.

Andrew




      reply	other threads:[~2004-03-25 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-24 23:03 Mark Kettenis
2004-03-25  0:26 ` Andrew Cagney
2004-03-25 10:26   ` Mark Kettenis
2004-03-25 14:42     ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4062EFD2.7000308@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox