From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26865 invoked by alias); 25 Mar 2004 00:26:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26854 invoked from network); 25 Mar 2004 00:26:08 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 25 Mar 2004 00:26:08 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 418502B9B; Wed, 24 Mar 2004 19:26:09 -0500 (EST) Message-ID: <40622721.6010603@gnu.org> Date: Thu, 25 Mar 2004 00:26:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: Signal Trampoline Frames References: <200403242303.i2ON33uL005973@elgar.kettenis.dyndns.org> In-Reply-To: <200403242303.i2ON33uL005973@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-03/txt/msg00583.txt.bz2 > Andrew, > > It's probably too late now, but I have the feeling this new > tramp-frame.c is not generic enough. It assumes fixed-length > instructions (which makes it unsuitable for IA-32 and AMD64) I didn't forget IA-32, I figured that it is always little endian so a sequence of one byte "insns" would work. > and uses > the arbitrary number 8 for the number of instructions (which makes it > not quite suitable for SPARC). I'm assuming people will increase it (It's like the arbitrary number 16 for the largest possible size of an instruction). > The whole thing seems a bit > over-engineered to me :-(. In what way? I wrote it after churn out 4 almost identical signal trampolines - so it works for one type but not for others. You also haven't seen my test cases :-) > Anyway, you might want to conseider the attached patch, which makes > the comments catch up with reality. The extra whitespace is there to > guide the eye and make the distinction between the instruction > sequence members and the initialization function clear. Andrew