Re: [patch] Bring QNX Neutrino support forward.

Daniel Jacobowitz
2004-03-31T22:21:23Z

Some small comments.

On Tue, Mar 23, 2004 at 04:18:56PM -0500, Kris Warkentin wrote:
> ChangeLog entry:
> * nto-tdep.h: Include osabi.h. Prototypes for generic Neutrino

Leading tabs in the ChangeLog entry, please :) Post what you would
check in.

> +#define nto_fetch_link_map_offsets \
> +(current_nto_target.nto_fetch_link_map_offsets)

I believe this should be indented. I'm not sure how far, I usually use
two spaces.

> - return openp (buf, 1, solib, o_flags, 0, temp_pathname);
> + /* Don't assume basename() isn't destructive. */
> + base = strrchr (solib, '/');
> + if (!base)
> + base = solib;
> + else
> + base++; /* Skip over '/'. */

There's an lbasename in libiberty, for this reason. You should use
that instead.

> + ret = openp (buf, 1, base, o_flags, 0, temp_pathname);
> + if (ret < 0 && base != solib)
> + {
> + sprintf (arch_path, "/%s", solib);
> + ret = open (arch_path, o_flags, 0);

Er... automatically falling back to the host library? Why?

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer