From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19220 invoked by alias); 22 Mar 2004 14:41:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19103 invoked from network); 22 Mar 2004 14:41:00 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 22 Mar 2004 14:41:00 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9B4772B9B; Mon, 22 Mar 2004 09:40:57 -0500 (EST) Message-ID: <405EFAF9.9000906@gnu.org> Date: Mon, 22 Mar 2004 14:41:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Ulrich Weigand Cc: gdb-patches@sources.redhat.com Subject: [commit] Zap XPASS from watchpoints.exp; Was: [PATCH] Remove XPASS on s390* References: <200403171918.UAA09557@faui1d.informatik.uni-erlangen.de> In-Reply-To: <200403171918.UAA09557@faui1d.informatik.uni-erlangen.de> Content-Type: multipart/mixed; boundary="------------070205040708010605060100" X-SW-Source: 2004-03/txt/msg00493.txt.bz2 This is a multi-part message in MIME format. --------------070205040708010605060100 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 524 > Hello, > > this patch removes an XPASS in the gdb.base/watchpoint.exp test case > by calling clear_xfail for s390* (as is already done for many other > targets). Hmm, you tripped over a landmine :-(. In the past many of GDB's testcases were incorrectly XFAILed (as a way of hiding design flaws that were thought to be unfixable / or the individual had no intention of fixing ...). XFAIL only applies to problems eXternal to GDB (OS bugs, ...) which these are not. I've removed the offending XFAIL junk. Andrew --------------070205040708010605060100 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1767 2004-03-22 Andrew Cagney * gdb.base/watchpoint.exp (test_stepping): Delete bogus XFAILs hiding problems with DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET. Problem identified by Ulrich Weigand. Index: gdb.base/watchpoint.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/watchpoint.exp,v retrieving revision 1.10 diff -u -r1.10 watchpoint.exp --- gdb.base/watchpoint.exp 6 Oct 2003 19:31:43 -0000 1.10 +++ gdb.base/watchpoint.exp 22 Mar 2004 14:23:09 -0000 @@ -374,31 +374,8 @@ gdb_test "break func2 if 0" "Breakpoint.*at.*" gdb_test "p \$func2_breakpoint_number = \$bpnum" " = .*" - # The problem is that GDB confuses stepping through the call - # dummy with hitting the breakpoint at the end of the call dummy. - # Will be fixed once all architectures define - # DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET. - setup_xfail "*-*-*" - # This doesn't occur if the call dummy starts with a call, - # because we are out of the dummy by the first time the inferior - # stops. - clear_xfail "arm*-*-*" - clear_xfail "xscale*-*-*" - clear_xfail "d10v*-*-*" - clear_xfail "m68*-*-*" - clear_xfail "i*86*-*-*" - clear_xfail "vax-*-*" - # The following architectures define DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET. - clear_xfail "alpha-*-*" - clear_xfail "mips*-*-*" - clear_xfail "sparc-*-*" - clear_xfail "hppa*-*-*bsd*" - # It works with the generic inferior function calling code too. - clear_xfail "mn10300*-*-*" - # The following architectures define CALL_DUMMY_HAS_COMPLETED. - clear_xfail "hppa*-*-*hpux*" gdb_test "p func1 ()" "= 73" \ - "calling function with watchpoint enabled" + "calling function with watchpoint enabled" # # "finish" brings us back to main. --------------070205040708010605060100--