From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51663-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8239 invoked by alias); 24 Oct 2007 22:23:19 -0000
Received: (qmail 8229 invoked by uid 22791); 24 Oct 2007 22:23:18 -0000
X-Spam-Check-By: sourceware.org
Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.170)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 Oct 2007 22:23:15 +0000
Received: by ug-out-1314.google.com with SMTP id m2so587115ugc         for <gdb-patches@sources.redhat.com>; Wed, 24 Oct 2007 15:23:13 -0700 (PDT)
Received: by 10.78.97.7 with SMTP id u7mr851622hub.1193264592711;         Wed, 24 Oct 2007 15:23:12 -0700 (PDT)
Received: by 10.78.188.17 with HTTP; Wed, 24 Oct 2007 15:23:12 -0700 (PDT)
Message-ID: <4053daab0710241523m28dba47dx99d50ac2030b4fde@mail.gmail.com>
Date: Wed, 24 Oct 2007 22:38:00 -0000
From: "Pedro Alves" <pedro_alves@portugalmail.pt>
To: "Joel Brobecker" <brobecker@adacore.com>,  	"Luis Machado" <luisgpm@linux.vnet.ibm.com>,  	gdb-patches@sources.redhat.com
Subject: Re: [patch] Backtrace prints wrong argument value
In-Reply-To: <4053daab0710241514s3a94f1fds6ef17c226546ccc4@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1190035779.4651.16.camel@localhost> 	 <20070917140416.GA15635@caradoc.them.org> 	 <1190049306.4651.42.camel@localhost> 	 <20070917171821.GA2107@caradoc.them.org> 	 <1192997096.5584.2.camel@localhost> 	 <20071021232837.GD6180@adacore.com> 	 <20071022010550.GA12211@caradoc.them.org> 	 <20071022033114.GB764@adacore.com> 	 <20071024204654.GP10943@caradoc.them.org> 	 <4053daab0710241514s3a94f1fds6ef17c226546ccc4@mail.gmail.com>
X-Google-Sender-Auth: c7d8e10c8ce84f1a
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00641.txt.bz2

Pedro Alves wrote:

> The fix is easy - inline the STRING_COMMA_LEN(NULL) cases.
> Wait, a quick 'grep STRING_COMMA_LEN * -rn | grep NULL' shows
> there aren't any?
>

:) Forgot to grep in ld.

There are only 6 of those in ld/pe-dll.c in a not-so-recent binutils checkout I
have here, so it should be painless.

Cheers,
Pedro Alves