From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31139 invoked by alias); 24 Oct 2007 13:03:38 -0000 Received: (qmail 31101 invoked by uid 22791); 24 Oct 2007 13:03:35 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.172) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 24 Oct 2007 13:03:31 +0000 Received: by ug-out-1314.google.com with SMTP id o2so341116uge for ; Wed, 24 Oct 2007 06:03:28 -0700 (PDT) Received: by 10.78.159.7 with SMTP id h7mr415957hue.1193231008195; Wed, 24 Oct 2007 06:03:28 -0700 (PDT) Received: by 10.78.188.17 with HTTP; Wed, 24 Oct 2007 06:03:28 -0700 (PDT) Message-ID: <4053daab0710240603k1efc5410r3c4eddb06979efd2@mail.gmail.com> Date: Wed, 24 Oct 2007 13:28:00 -0000 From: "Pedro Alves" To: "Ulrich Weigand" Subject: Re: Avoid gcc warning on sparc solaris 9 Cc: gdb-patches@sourceware.org In-Reply-To: <200710231710.l9NHAUtT006558@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3788_24035081.1193231008180" References: <4053daab0710230924o386935aer31a1a2fb4f70da31@mail.gmail.com> <200710231710.l9NHAUtT006558@d12av02.megacenter.de.ibm.com> X-Google-Sender-Auth: 0146ea45395033ef X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00573.txt.bz2 ------=_Part_3788_24035081.1193231008180 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 871 Ulrich Weigand wrote: > Pedro Alves wrote: > > > Building HEAD on a native gdb on sparc solaris 9 with gcc 3.4.6 stops due to: > > > > ../../src/gdb/sol-thread.c: In function `sol_thread_fetch_registers': > > ../../src/gdb/sol-thread.c:533: warning: dereferencing type-punned > > pointer will break strict-aliasing rules > > We've seen this on other platforms with gcc 3.4 as well. I think > the best fix would be replace the problematic construct > supply_gregset (regcache, (const gdb_gregset_t *) &gregset); > with > > gdb_gregset_t *gregset_p = &gregset; > > supply_gregset (regcache, (const gdb_gregset_t *) gregset_p); > > That seemed to fix the problems e.g. in i386-linux-nat.c (fetch_regs). > Indeed it does fix it here too. Much nicer. Thanks for the pointer. Testsuite shows the same results as the previous version. OK now? -- Cheers, Pedro Alves ------=_Part_3788_24035081.1193231008180 Content-Type: text/x-patch; name=solaris.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_f85uw9cd Content-Disposition: attachment; filename=solaris.diff Content-length: 1688 MjAwNy0xMC0yNCAgUGVkcm8gQWx2ZXMgIDxwZWRyb19hbHZlc0Bwb3J0dWdh bG1haWwucHQ+CgoJKiBzb2wtdGhyZWFkLmMgKHNvbF90aHJlYWRfZmV0Y2hf cmVnaXN0ZXJzKTogV29yayBhcm91bmQgZ2NjIDMuNAoJYWxpYXMgd2Fybmlu ZyBidWcuCgotLS0KIGdkYi9zb2wtdGhyZWFkLmMgfCAgICA3ICsrKysrLS0K IDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCgpJbmRleDogc3JjL2dkYi9zb2wtdGhyZWFkLmMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gc3JjLm9yaWcvZ2RiL3NvbC10aHJlYWQuYwkyMDA3 LTEwLTIzIDE3OjA3OjA3LjYwNDczMDAwMCArMDEwMAorKysgc3JjL2dkYi9z b2wtdGhyZWFkLmMJMjAwNy0xMC0yNCAxMzozNTozNy4zODA0NzQwMDAgKzAx MDAKQEAgLTQ4NCw2ICs0ODQsOSBAQCBzb2xfdGhyZWFkX2ZldGNoX3JlZ2lz dGVycyAoc3RydWN0IHJlZ2NhCiAgIHRkX2Vycl9lIHZhbDsKICAgcHJncmVn c2V0X3QgZ3JlZ3NldDsKICAgcHJmcHJlZ3NldF90IGZwcmVnc2V0OworICBn ZGJfZ3JlZ3NldF90ICpncmVnc2V0X3AgPSAmZ3JlZ3NldDsKKyAgZ2RiX2Zw cmVnc2V0X3QgKmZwcmVnc2V0X3AgPSAmZnByZWdzZXQ7CisKICNpZiAwCiAg IGludCB4cmVnc2l6ZTsKICAgY2FkZHJfdCB4cmVnc2V0OwpAQCAtNTMwLDgg KzUzMyw4IEBAIHNvbF90aHJlYWRfZmV0Y2hfcmVnaXN0ZXJzIChzdHJ1Y3Qg cmVnY2EKICAgICAgY2FsbGluZyB0aGUgdGQgcm91dGluZXMgYmVjYXVzZSB0 aGUgdGQgcm91dGluZXMgY2FsbCBwc19sZ2V0KgogICAgICB3aGljaCBhZmZl Y3QgdGhlIHZhbHVlcyBzdG9yZWQgaW4gdGhlIHJlZ2lzdGVycyBhcnJheS4g ICovCiAKLSAgc3VwcGx5X2dyZWdzZXQgKHJlZ2NhY2hlLCAoY29uc3QgZ2Ri X2dyZWdzZXRfdCAqKSAmZ3JlZ3NldCk7Ci0gIHN1cHBseV9mcHJlZ3NldCAo cmVnY2FjaGUsIChjb25zdCBnZGJfZnByZWdzZXRfdCAqKSAmZnByZWdzZXQp OworICBzdXBwbHlfZ3JlZ3NldCAocmVnY2FjaGUsIChjb25zdCBnZGJfZ3Jl Z3NldF90ICopIGdyZWdzZXRfcCk7CisgIHN1cHBseV9mcHJlZ3NldCAocmVn Y2FjaGUsIChjb25zdCBnZGJfZnByZWdzZXRfdCAqKSBmcHJlZ3NldF9wKTsK IAogI2lmIDAKICAgLyogRklYTUU6IGxpYnRocmVhZF9kYiBkb2Vzbid0IHNl ZW0gdG8gaGFuZGxlIHRoaXMgcmlnaHQuICAqLwo= ------=_Part_3788_24035081.1193231008180--