Re: Support of gdb for Windows 64 native systems

Christopher Faylor
2007-10-15T18:39:15Z

On Mon, Oct 15, 2007 at 12:14:01AM +0100, Pedro Alves wrote:
> Christopher Faylor wrote:
>> On Sun, Oct 14, 2007 at 07:02:26PM +0100, Pedro Alves wrote:
>>> Christopher Faylor wrote:
>>>>> + flags = DEBUG_ONLY_THIS_PROCESS;
>>>>> + toexec = exec_file;
>>>> This doesn't seem right. You moved this setting outside of an if block
>>>> and didn't accommodate the else condition.
>>> I didn't move it. The if inside the __CYGWIN__ block sets TOEXEC in both
>>> branches.
>> I'm talking about "flags".
>
> Sorry, should have realized it.
>
> Maybe I'm too tired, but I really can't see what's <logically> not
> right :(

You took a 'flags = ' out of the first part of an if/else block and put
it before the if block. Doesn't that seem wrong?

cgf