From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51438-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17277 invoked by alias); 16 Oct 2007 07:53:16 -0000
Received: (qmail 17269 invoked by uid 22791); 16 Oct 2007 07:53:16 -0000
X-Spam-Check-By: sourceware.org
Received: from nf-out-0910.google.com (HELO nf-out-0910.google.com) (64.233.182.187)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 16 Oct 2007 07:53:13 +0000
Received: by nf-out-0910.google.com with SMTP id b11so1589525nfh         for <gdb-patches@sourceware.org>; Tue, 16 Oct 2007 00:53:11 -0700 (PDT)
Received: by 10.78.160.4 with SMTP id i4mr4640232hue.1192521190145;         Tue, 16 Oct 2007 00:53:10 -0700 (PDT)
Received: by 10.78.188.17 with HTTP; Tue, 16 Oct 2007 00:53:10 -0700 (PDT)
Message-ID: <4053daab0710160053v56c78dael4a8c732c3b7d70d7@mail.gmail.com>
Date: Tue, 16 Oct 2007 11:57:00 -0000
From: "Pedro Alves" <pedro_alves@portugalmail.pt>
To: gdb-patches@sourceware.org, "Eli Zaretskii" <eliz@gnu.org>
Subject: Re: Support of gdb for Windows 64 native systems
In-Reply-To: <20071016042121.GA22246@ednor.casa.cgf.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20071014051622.GC13789@adacore.com> 	 <20071014173921.GD11619@ednor.casa.cgf.cx> 	 <471259B2.6050808@portugalmail.pt> 	 <20071014221603.GA13096@ednor.casa.cgf.cx> 	 <20071014222252.GA13023@caradoc.them.org> 	 <20071015184525.GI14543@ednor.casa.cgf.cx> 	 <20071015185451.GA3934@caradoc.them.org> 	 <4713F838.9050104@portugalmail.pt> <ur6jvitow.fsf@gnu.org> 	 <20071016042121.GA22246@ednor.casa.cgf.cx>
X-Google-Sender-Auth: c9399d7580efec44
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00416.txt.bz2

On 10/16/07, Christopher Faylor wrote:
> On Tue, Oct 16, 2007 at 06:12:31AM +0200, Eli Zaretskii wrote:
> >> Date: Tue, 16 Oct 2007 00:31:04 +0100
> >> From: Pedro Alves <pedro_alves@portugalmail.pt>
> >>
> >> How about the attached?
> >
> >I have one concern:
> >
> >> -#include <sys/procfs.h>
> >
> >Why do you unconditionally remove this include?  Doesn't the Cygwin
> >build want it?
>
> Actually, I wondered about this too and meant to ask.  I assume that it
> isn't really needed?
>

I did explain it upthread:
" - profs.h isn't needed anymore, since I've implemented cygwin cross-core
support a few weeks ago (in i386-cygwin-tdep.c).  The include can be
       unconditionally removed."

The #include was introduced in Egor's original core support patch.

sys/procfs.h:

#ifndef _SYS_PROCFS_H
#define _SYS_PROCFS_H

#include <cygwin/core_dump.h>

#endif /* _SYS_PROCFS_H */

cygwin/core_dump.h describes the structures used in Cygwin core files.

Gdb doesn't use them anymore.  Instead the structures are read in
host-independent form in i386-cygwin-tdep.c:core_process_module_section.

Cheers,
Pedro Alves