From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16739 invoked by alias); 5 Sep 2007 08:46:39 -0000 Received: (qmail 16728 invoked by uid 22791); 5 Sep 2007 08:46:38 -0000 X-Spam-Check-By: sourceware.org Received: from nf-out-0910.google.com (HELO nf-out-0910.google.com) (64.233.182.188) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Sep 2007 08:46:29 +0000 Received: by nf-out-0910.google.com with SMTP id d3so1654479nfc for ; Wed, 05 Sep 2007 01:46:26 -0700 (PDT) Received: by 10.78.171.20 with SMTP id t20mr4951450hue.1188981986001; Wed, 05 Sep 2007 01:46:26 -0700 (PDT) Received: by 10.78.192.16 with HTTP; Wed, 5 Sep 2007 01:46:25 -0700 (PDT) Message-ID: <4053daab0709050146h137c9278ke2f44a1ffb353508@mail.gmail.com> Date: Wed, 05 Sep 2007 08:46:00 -0000 From: "Pedro Alves" To: gdb-patches@sourceware.org Subject: Re: Windows DLL support update (a bit slimmer version) In-Reply-To: <20070903174605.GK12440@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <46C8BEC4.3030807@portugalmail.pt> <20070903174605.GK12440@caradoc.them.org> X-Google-Sender-Auth: dddabc03f6ec7493 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00075.txt.bz2 On 9/3/07, Daniel Jacobowitz wrote: > On Sun, Aug 19, 2007 at 11:05:56PM +0100, Pedro Alves wrote: > > 2007-08-19 Pedro Alves > > Daniel Jacobowitz > > > > * infcmd.c (post_create_inferior): Update comment. > > (run_command_1): Always call post_create_inferior with 0 as > > from_tty. > > > > * i386-cygwin-tdep.h: New. > > * i386-cygwin-tdep.c: Include "i386-cygwin-tdep.h". > > (win32_xfer_shared_library): Make it extern. > > > > * win32-nat.c: Include gdb_obstack.h and xml-support.h and > > i386-cygwin-tdep.h. > > (win32_so_ops): Delete. > > (get_relocated_section_addrs): Delete. > > (solib_symbols_add): Delete. > > (register_loaded_dll): Delete. > > (win32_make_so): New. > > (handle_load_dll): Use win32_make_so. > > (win32_free_so): Free the passed in so. > > (win32_relocate_section_addresses): Delete. > > (win32_solib_create_inferior_hook): Delete. > > (handle_unload_dll): Don't add PE offset here. Free so with > > win32_free_so instead of free_so. > > (win32_special_symbol_handling): Delete. > > (get_win32_debug_event): Remove unneeded calls. Set state to > > TARGET_WAITKIND_LOADED on a dll unload. > > (do_initial_win32_stuff): Clear cygwin_load_start and > > cygwin_load_end. > > (map_code_section_args): Delete. > > (dll_code_sections_add): Delete. > > (core_section_load_dll_symbols): Delete. > > (win32_xfer_shared_libraries): New. > > (win32_current_sos): Delete. > > (win32_xfer_partial): New. > > (open_symbol_file_object): Delete. > > (in_dynsym_resolve_code): Delete. > > (init_win32_ops): Set win32_xfer_partial as to_xfer_partial member > > of win32_ops. Remove win32_so_ops settings. Don't set > > current_target_so_ops here. > > > > * Makefile.in (i386_cygwin_tdep_h): New variable. > > (i386-cygwin-tdep.o): Update dependencies. > > (win32-nat.o): Update dependencies. > > This is OK to commit. > Thanks for all the review, Checked in. Cheers, Pedro Alves