Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [committed][gdb/symtab] Make find_block_in_blockvector more robust
Date: Thu, 22 Oct 2020 17:42:01 -0400	[thread overview]
Message-ID: <4052e022-30fd-b24e-2ad6-53eb4d790d85@simark.ca> (raw)
In-Reply-To: <8d84b50e-530a-a33c-b523-c72305438c19@suse.de>

On 2020-10-22 5:21 p.m., Tom de Vries wrote:
> On 10/22/20 8:56 PM, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> +      if (!(BLOCK_START (b) <= pc))
>> Tom> +	return NULL;
>>
>> This seems a bit weird to me, in that if BLOCK_START(b) == pc, then I
>> would be inclined to say that the pc is in fact in that block.
>>
>
> So if BLOCK_START(b) == pc, indeed the pc is in the block, and we have:
> ...
>       if (!(true))
> 	return NULL;
> ...
> which I'd say correctly handles that case.
>
> Thanks,
> - Tom
>

I think that turning:

  if (!(BLOCK_START (b) <= pc))

into

  if (BLOCK_START (b) > pc)

or

  if (pc < BLOCK_START (b))

would make it easier to read.

Simon

  reply	other threads:[~2020-10-22 21:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22 15:24 Tom de Vries
2020-10-22 18:56 ` Tom Tromey
2020-10-22 21:21   ` Tom de Vries
2020-10-22 21:42     ` Simon Marchi [this message]
2020-10-23 14:08       ` Tom de Vries
2020-10-23 15:42         ` Simon Marchi
2020-10-23 12:42     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4052e022-30fd-b24e-2ad6-53eb4d790d85@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox