From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8Jt2GzTwD2YqYiQAWB0awg (envelope-from ) for ; Fri, 05 Apr 2024 08:36:04 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MNnxUfdZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 692D11E0C0; Fri, 5 Apr 2024 08:36:04 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4E7FD1E030 for ; Fri, 5 Apr 2024 08:36:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F198638449C7 for ; Fri, 5 Apr 2024 12:36:01 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 834793858431 for ; Fri, 5 Apr 2024 12:33:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 834793858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 834793858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712320424; cv=none; b=QnBapXOr+jOXxTgUws93YlN3ZthoH/s3m5yv4O2EEm+zDOtrPjKYwHhC5HJuzaHB2EoIQnGpv2b9auMm+IPQ6iRDbenfTvnkrXT/FzZYzdmCRJmNT22nSvkJr4LRlPjup91Rrkm5JAe93hY0v+6waVynsaDgCXaFGAEquZ4Pv6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712320424; c=relaxed/simple; bh=LVChTPs2mlXJ+9DSy2NHZ3IofYVJl3nKW6RWqyXy5sU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Q1aBNGcUJEFgGOswNtnBnF6bx+rn6i6/c044P50AnBgj8xWlOck+H4UxCV1Pq1U7rl6xjsXZ+WaR/kf0RlXv7/eh636t1YkM9TIqJzYwN2shOrxP7YbAjrzA2oY6VGsRRYlE1tJOE1lrvvPX4M6QQtVnJQtxXfVHwREMm0r8aDg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712320422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FGXK8MNHbksShJw2aRkkwQP1sNkoss8ecPxgHYoGUOk=; b=MNnxUfdZcdEXf0fTXSS/xAbU0KbiR2g1JsZwqpiJVNTpD28p7L2A8YKMBnkhnVbA/Un/rE 7r4PzfkvELYBMi+ZDt7/AXnMOrJ9QYJjZCG3K2VvPe0y9C0NtSYLYKQlVSx+8zqKLj9uyD LGRhdtmB5ex183EFEN9Xzt6RMuGpxvk= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-bioSY8IRPJOhSqUhWjPSsg-1; Fri, 05 Apr 2024 08:33:40 -0400 X-MC-Unique: bioSY8IRPJOhSqUhWjPSsg-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-56c1b105949so1909358a12.3 for ; Fri, 05 Apr 2024 05:33:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712320419; x=1712925219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FGXK8MNHbksShJw2aRkkwQP1sNkoss8ecPxgHYoGUOk=; b=vZ0vBOZFiyD9mM5hVAOzBf+xGy0TFmzW0sUjzyKTvxowaxDKIhqhi+V4rhq7mnMl0c KNl+L6dahpMxPnb7BSS+y/TMO94j15SxpPalobOlxwgfJbUcIF6sTk5sGuTqTPP6x/R8 DniheCz5bM92TUyv966zxWM9Q6rmcr6MdJu3ZY+l8cUaEMEER6KkYcF9V2bRMHxVyfF4 SerDrrqwGMHZaJcwQODzFwAiByblETLuFiEaqN8/nDao3u1yonyWl+ryYRe9i195FFd1 4Ff5zzfiN8oFBW5m4+ivNF2PjdN8JoYTX0O6ra1/5xF8OG6i7NV3+kjOhUKuI+tDdHJk t+xg== X-Gm-Message-State: AOJu0YyCyu37WRl1Ow+3q6I8kX5u6bxsxqB49u9++QBw3toJPRsm7H1d bGExbFjTv+sUG/w/t6kpG13o/qi6eGFkoQwv7N/EnrwPKqbEQTASu1Xi7WQ1szXc89M/DkzInso Iu35/HrTF9AdXs1jt8opzGUP2scFxTMyKJ3Fk9thAcQiadFNY+nfJWq3klnO3E9vBptyzf91tRM XymcAAyVrlIateeukAcOrTeMHtdd0Oq1HwaoY1DB4iiFw= X-Received: by 2002:a50:8e5b:0:b0:56e:23e3:bdc3 with SMTP id 27-20020a508e5b000000b0056e23e3bdc3mr964057edx.16.1712320419574; Fri, 05 Apr 2024 05:33:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdT6fxBbd2e004aMKAd2ERvpfLIi+KzA6WPaviiu+pBOho5kWdDxuPFdZzI5WwaemrspMG/Q== X-Received: by 2002:a50:8e5b:0:b0:56e:23e3:bdc3 with SMTP id 27-20020a508e5b000000b0056e23e3bdc3mr963963edx.16.1712320415205; Fri, 05 Apr 2024 05:33:35 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id ck6-20020a0564021c0600b0056e2bf42d0fsm773595edb.49.2024.04.05.05.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 05:33:34 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv4 07/10] gdb/arch: assert that X86_XSTATE_MPX is not set for x32 Date: Fri, 5 Apr 2024 13:33:17 +0100 Message-Id: <40475ef7aa9325c0802eb86018d642024b26a28e.1712245988.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org While rebasing this series past this commit: commit 4bb20a6244b7091a9a7a2ae35dfbd7e8db27550a Date: Wed Mar 20 04:13:18 2024 -0700 gdbserver: Clear X86_XSTATE_MPX bits in xcr0 on x32 I worried that there could be other paths that might result in an xcr0 value which has X86_XSTATE_MPX set in x32 mode. As everyone eventually calls amd64_create_target_description to build their target description, I figured we could assert in here that if X86_XSTATE_MPX is set then we should not be an x32 target, this will uncover any other bugs in this area. I'm not currently able to build/run any x32 binaries, so I have no way to test this, but the author of commit 4bb20a6244b7091 did test this series with that assert in place and didn't see any problems. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31511 --- gdb/arch/amd64.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c index cb9683c6931..94d55d72a4e 100644 --- a/gdb/arch/amd64.c +++ b/gdb/arch/amd64.c @@ -65,8 +65,12 @@ amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux, if (xcr0 & X86_XSTATE_AVX) regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum); - if ((xcr0 & X86_XSTATE_MPX) && !is_x32) - regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum); + if (xcr0 & X86_XSTATE_MPX) + { + /* MPX is not available on x32. */ + gdb_assert (!is_x32); + regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum); + } if (xcr0 & X86_XSTATE_AVX512) regnum = create_feature_i386_64bit_avx512 (tdesc.get (), regnum); -- 2.25.4