Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFC 2/2] Move gdb's xmalloc and friends to new file
Date: Mon, 03 Jun 2019 15:03:00 -0000	[thread overview]
Message-ID: <4042ab05-d68e-15b7-a025-e51b679b376a@simark.ca> (raw)
In-Reply-To: <20190530213046.20542-3-tom@tromey.com>

On 2019-05-30 5:30 p.m., Tom Tromey wrote:
> When "common" becomes a library, linking will cause a symbol clash,
> because "xmalloc" and some related symbols are defined in that
> library, libiberty, and readline.
> 
> To work around this problem, this patch moves the clashing symbols to
> a new file, which is then compiled separately for both gdb and
> gdbserver.

Hmm how does this work currently?  We have an xmalloc symbols both in
common/common-utils.o and ../libiberty/libiberty.a, why doesn't it clash?

Simon


  reply	other threads:[~2019-06-03 15:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 21:30 [RFC 0/2] Let's discuss moving gdbserver to top-level Tom Tromey
2019-05-30 21:30 ` [RFC 2/2] Move gdb's xmalloc and friends to new file Tom Tromey
2019-06-03 15:03   ` Simon Marchi [this message]
2019-06-03 16:33     ` Tom Tromey
2019-06-05  9:40   ` Pedro Alves
2019-06-05 22:33     ` Tom Tromey
2019-06-17 15:45   ` Alan Hayward
2019-06-17 17:43     ` Tom Tromey
2019-06-17 18:37       ` Pedro Alves
2019-06-18  9:31         ` Alan Hayward
2019-07-03 16:18           ` Alan Hayward
2019-07-13 16:04             ` Tom Tromey
2019-07-16 19:47             ` Pedro Alves
2019-05-30 21:30 ` [RFC 1/2] Remove linux-waitpid.c debugging code Tom Tromey
2019-06-03 14:57   ` Simon Marchi
2019-06-03 16:32     ` Tom Tromey
2019-06-05  9:32       ` Pedro Alves
2019-06-03 10:24 ` [RFC 0/2] Let's discuss moving gdbserver to top-level Alan Hayward
2019-06-03 14:27 ` Simon Marchi
2019-06-03 16:30   ` Tom Tromey
2019-06-05  9:16 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4042ab05-d68e-15b7-a025-e51b679b376a@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox