From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25652 invoked by alias); 1 Mar 2004 01:33:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25645 invoked from network); 1 Mar 2004 01:33:15 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 1 Mar 2004 01:33:15 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1B5222B92; Sun, 29 Feb 2004 20:33:12 -0500 (EST) Message-ID: <404292D7.9040100@gnu.org> Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Jason R Thorpe , gdb-patches@sources.redhat.com Subject: Re: [rfa:NetBSD/ppc] Implement signal trampoline unwinder References: <40428C58.1020506@gnu.org> <20040301012656.GA16265@nevyn.them.org> In-Reply-To: <20040301012656.GA16265@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-03/txt/msg00005.txt.bz2 > On Sun, Feb 29, 2004 at 08:05:28PM -0500, Andrew Cagney wrote: > >>> It appears to work (but doesn't have much effect without an rs6000 >>> unwinder). >>> >>> One question (and to follow up my earlier post) is there a better way of >>> doing this: >>> >>> + if (frame_pc_unwind (next_frame) > 0x7f000000) >>> + /* Assume anything that is vaguely on the stack is a signal >>> + trampoline. */ >>> + return &ppcnbsd_sigtramp_unwind; >>> >>> ok?, eventually for 6.1? > > > For other targets, we grub in the code for the sigtramp instruction > sequence. I'm betting it's fixed for NetBSD too? ppc_linux_in_sigtramp > does this. That's potentially expensive - there should also be a predicate like the above before the stack is read checked. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25652 invoked by alias); 1 Mar 2004 01:33:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25645 invoked from network); 1 Mar 2004 01:33:15 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 1 Mar 2004 01:33:15 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1B5222B92; Sun, 29 Feb 2004 20:33:12 -0500 (EST) Message-ID: <404292D7.9040100@gnu.org> Date: Mon, 01 Mar 2004 01:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Jason R Thorpe , gdb-patches@sources.redhat.com Subject: Re: [rfa:NetBSD/ppc] Implement signal trampoline unwinder References: <40428C58.1020506@gnu.org> <20040301012656.GA16265@nevyn.them.org> In-Reply-To: <20040301012656.GA16265@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-03.o/txt/msg00005.txt Message-ID: <20040301013300.3mAnqliKnh8NtNm4PrlTvSqJ0f3Y2wJtOs-lWcPlbpg@z> > On Sun, Feb 29, 2004 at 08:05:28PM -0500, Andrew Cagney wrote: > >>> It appears to work (but doesn't have much effect without an rs6000 >>> unwinder). >>> >>> One question (and to follow up my earlier post) is there a better way of >>> doing this: >>> >>> + if (frame_pc_unwind (next_frame) > 0x7f000000) >>> + /* Assume anything that is vaguely on the stack is a signal >>> + trampoline. */ >>> + return &ppcnbsd_sigtramp_unwind; >>> >>> ok?, eventually for 6.1? > > > For other targets, we grub in the code for the sigtramp instruction > sequence. I'm betting it's fixed for NetBSD too? ppc_linux_in_sigtramp > does this. That's potentially expensive - there should also be a predicate like the above before the stack is read checked. Andrew