> Date: Sat, 28 Feb 2004 10:22:29 -0500 > From: Andrew Cagney > > > Date: Thu, 26 Feb 2004 20:24:47 -0500 > > From: Andrew Cagney > > > > Hello, > > > > This modifies the amd64 code so that, when 32-bit, it fetches the 32-bit > > thread area register (I think this has been posted before?). > > > > Why #if 0 ... #else ... #endif? > > Tipo from testing. > > Typo? You mean that you intended to remove the #if 0 block before > submitting the patch? Or what? Yes, "tipo". As Stan Shebs where the word comes from. > > Anyway, I'm not really happy with the > > > > switch (TARGET_ARCHITECTURE->mach) > > > > construction. The other AMD64 native code uses an > > > > if (gdbarch_ptr_bit (current_gdbarch) == 32) > > > > to distinguish between 32-bit and 64-bit code. While this may not be > > completely correct (someone might come up with a native AMD64 ABI with > > 32-bit pointers), I'd rather not use multiple variations of the > > 32-bit/64-bit check in the code. > > Is it ok with that change? > > If you remove the #if 0 block and re-indent the #else block. Yes. Done. Committed the attached. Andrew