From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25166 invoked by alias); 28 Feb 2004 19:32:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25158 invoked from network); 28 Feb 2004 19:32:57 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 28 Feb 2004 19:32:57 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A92492B92; Sat, 28 Feb 2004 14:32:55 -0500 (EST) Message-ID: <4040ECE7.8010607@gnu.org> Date: Sat, 28 Feb 2004 19:32:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [ob] Don't clobber inferior_ptid in read_pc_pid References: <20040228173541.GA15776@nevyn.them.org> In-Reply-To: <20040228173541.GA15776@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00855.txt.bz2 > Another issue found in testing on arm-linux. A return was added to this > function back in June; if we return from the middle of it, we leave > inferior_ptid set to the wrong thread. This causes a "!ptid_equal > (ecs->ptid, inferior_ptid)" test to fail, since we called read_pc_pid > with ecs->ptid. That leads to not calling context_switch; which clobbers > the stepping range for the previous thread; which causes stepping to stop > unexpectedly. > > I'll commit this patch as obvious in a day or two. Can you please commit it now? Andrew