From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23852 invoked by alias); 28 Feb 2004 16:59:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23659 invoked from network); 28 Feb 2004 16:59:14 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 28 Feb 2004 16:59:14 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 02F1E2B92; Sat, 28 Feb 2004 11:21:45 -0500 (EST) Message-ID: <4040C019.6090601@gnu.org> Date: Sat, 28 Feb 2004 16:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix compilation of tui/tui.c References: <200402281503.i1SF3p8g011820@elgar.kettenis.dyndns.org> <4040B1D7.4090805@gnu.org> <200402281547.i1SFlv87012449@elgar.kettenis.dyndns.org> In-Reply-To: <200402281547.i1SFlv87012449@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00827.txt.bz2 > What portability problem. > > The TUI code is including header files and using library functions > that we've never used before in GDB. We've already seen the fall-out > from this on HP-UX and Solaris, and now on FreeBSD. I'm just afraid > that more of these problems will surface when somebody tries to build > GDB other platforms. There aren't that many other systems left! As with off64_t, while certainly a step into the unknown, we've done our homework - notice, paced patches, and testing it on a varity of systems. The only real way to flush out the remaining problems is to push it through to a release. > Is there a reason for changing "" to <>, it breaks some of GDB's > scripts. > > I changed because we seem to use <> everywhere else in GDB for the > readline includes, e.g. event-top.c, completer.c. I think it's good > to be consistent; you get less surprises that way. I'll change them so that they are consistent. gdb_makefile.sh: http://sources.redhat.com/gdb/current/ari/gdb_makefile.sh knows about "..." includes. Andrew