From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12341 invoked by alias); 28 Feb 2004 15:22:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12334 invoked from network); 28 Feb 2004 15:22:31 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 28 Feb 2004 15:22:31 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id CD0152B98; Sat, 28 Feb 2004 10:22:29 -0500 (EST) Message-ID: <4040B235.2090405@gnu.org> Date: Sat, 28 Feb 2004 15:22:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Mark Kettenis Cc: ac131313@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [rfa:amd64] Fetch 32-bit thread area References: <403E9C5F.2050803@redhat.com> <200402281151.i1SBpN4u000732@elgar.kettenis.dyndns.org> In-Reply-To: <200402281151.i1SBpN4u000732@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00822.txt.bz2 > Date: Thu, 26 Feb 2004 20:24:47 -0500 > From: Andrew Cagney > > Hello, > > This modifies the amd64 code so that, when 32-bit, it fetches the 32-bit > thread area register (I think this has been posted before?). > > Why #if 0 ... #else ... #endif? Tipo from testing. > Anyway, I'm not really happy with the > > switch (TARGET_ARCHITECTURE->mach) > > construction. The other AMD64 native code uses an > > if (gdbarch_ptr_bit (current_gdbarch) == 32) > > to distinguish between 32-bit and 64-bit code. While this may not be > completely correct (someone might come up with a native AMD64 ABI with > 32-bit pointers), I'd rather not use multiple variations of the > 32-bit/64-bit check in the code. Is it ok with that change? Andrew