From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15680 invoked by alias); 26 Feb 2004 23:47:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15645 invoked from network); 26 Feb 2004 23:47:42 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 26 Feb 2004 23:47:42 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id B900280001E; Thu, 26 Feb 2004 18:47:41 -0500 (EST) Message-ID: <403E859D.9020902@redhat.com> Date: Thu, 26 Feb 2004 23:47:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC]: new set breakpoint pending and show breakpoint pending commands References: <402974E1.8090909@redhat.com> <40353913.7020406@redhat.com> <403E51B4.3070005@redhat.com> <403E5603.6010203@gnu.org> In-Reply-To: <403E5603.6010203@gnu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00789.txt.bz2 Andrew Cagney wrote: >> Double Ping ... > > > Thought I'd covered it, sorry. Yes, ok (and finally some more sanity in > GDB's cli structure!) > > Can you create a breakpoint bug report to move all the other breakpoint > options into "set/show breakpoint". > > Andrew > Done. See gdb/1575. Patch checked in. Thanks. -- Jeff J. >> Jeff Johnston wrote: >> >>> Ping...[excluding Eli who graciously reviewed the doc change] >>> >>> Jeff Johnston wrote: >>> >>>> The following patch adds a setting to control how gdb creates >>>> pending breakpoints. At Andrew's suggestion, I have made the >>>> setting a subsetting of breakpoint so future breakpoint settings >>>> will all be grouped together. >>>> >>>> The setting is an auto boolean and has three settings: on, off, and >>>> auto. The default behavior is auto which is the current default >>>> behavior of querying before setting a pending breakpoint. The on >>>> setting causes pending breakpoints to be created automatically >>>> without prompting and the off setting causes no pending breakpoints >>>> to be created. The off setting causes an error to occur which >>>> matches the previous behavior Andrew was seeing with regard to scripts. >>>> >>>> I have included a doc patch but will wait on posting a change to >>>> pending.exp until everyone is ok with the interface. A change is >>>> not required to make pending.exp work, it would just exercise the >>>> new functionality. I have tested the new settings manually. >>>> >>>> Ok? >>>> >>>> -- Jeff J. >>>> >>>> gdb/ChangeLog: >>>> >>>> 2004-02-10 Jeff Johnston >>>> >>>> * breakpoint.c (pending_break_support): New setting variable. >>>> (break_command_1): Account for pending_break_support setting >>>> when creating pending breakpoints. >>>> (set_breakpoint_cmd, show_breakpoint_cmd): New functions. >>>> (_initialize_breakpoint): Add "set breakpoint pending" and >>>> "show breakpoint pending" commands. >>>> >>>> doc/ChangeLog: >>>> >>>> 2004-02-10 Jeff Johnston >>>> >>>> * gdb.texinfo (breakpoints): Add information about the >>>> new "set breakpoint pending" and "show breakpoint pending" >>>> commands. >>>> >>>> > >