Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: fnf@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix incorrect use of "until" command in gdb.arch/gdb1431
Date: Thu, 26 Feb 2004 23:01:00 -0000	[thread overview]
Message-ID: <403E7AA2.8050805@gnu.org> (raw)
In-Reply-To: <200402261529.01301.fnf@ninemoons.com>

> On Thursday 26 February 2004 14:04, Andrew Cagney wrote:
> 
>>> Hmm, "How did it ever work"? :-)
> 
> 
> From what I could tell, at one time "until" did work like "advance".
> There is a pretty long thread about it on the gdb or gdb-patches list,
> though I can't seem to find it again with a quick search.

Ah, that would explain it.

The current "finish" behavior is the original "finish" behavior.  There 
was a period (of several years) during which "finish" was broken.  I 
guess the test was written during that period (or with such a broken 
GDB).  "advance" came about because people wanted both the correct and 
broken behavior ....

Andrew


>>> I guess so, but keep the 1431.c specific test file
> 
> 
> OK, I kept a distinct file for this test, but one that is cloned from
> the 1291 test to be all assembly instead of mixed C/assembly.  There
> is a previously reported gcc bug that causes line numbers to be
> botched in the mix C/assembly case, obscuring what we are trying to
> test for here.
> 
> I committed the following patch.



      reply	other threads:[~2004-02-26 23:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-20  3:03 Fred Fish
2004-02-26 21:04 ` Andrew Cagney
2004-02-26 22:29   ` Fred Fish
2004-02-26 23:01     ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=403E7AA2.8050805@gnu.org \
    --to=cagney@gnu.org \
    --cc=fnf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox