From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27334 invoked by alias); 26 Feb 2004 17:41:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27145 invoked from network); 26 Feb 2004 17:41:36 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 26 Feb 2004 17:41:36 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4D4B72B92; Thu, 26 Feb 2004 12:41:34 -0500 (EST) Message-ID: <403E2FCE.6090607@gnu.org> Date: Thu, 26 Feb 2004 17:41:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: "Nathan J. Williams" , gdb-patches@sources.redhat.com Subject: Re: [patch] Gdbserver error codes References: <20040226151034.GA24170@nevyn.them.org> <20040226170935.GA9354@nevyn.them.org> In-Reply-To: <20040226170935.GA9354@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00769.txt.bz2 > On Thu, Feb 26, 2004 at 12:08:08PM -0500, Nathan J. Williams wrote: > >>> Daniel Jacobowitz writes: >>> >> >>>> > Thanks to Eli for making me look closer at this. Parts of remote.c >>>> > will reject ENN; in particular, ENN will cause remote_write_bytes to return >>>> > an error but remote_read_bytes not to. Thus the 0xffffffff gdbserver has >>>> > been printing instead of an error message for inaccessible memory regions. >> >>> >>> I still don't see that gdbserver will actually return an error if the >>> memory read fails; the target_ops read routine doesn't return an error >>> to the upper level, and the low transfer routines don't check the >>> ptrace return value and errno. I can put together my patches to >>> address this if there's interest. > > > Oops, you're right. > > Of course there is interest - I'm always interested in fixes to > gdbserver. Do you have or can you get a copyright assignment? Wasabi have a blanket assignment. >>> (while I'm at it, is there anything specifying that the hex format for >>> returned data is lowercase hex, or is the capital-E error return the only >>> implicit statement of that?) > > > I have no idea. In general? Assume its lowercase. No, it probably isn't explicit. Andrew