Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] The off again, on again, PC == 0 in get_prev_frame
Date: Sun, 22 Feb 2004 17:40:00 -0000	[thread overview]
Message-ID: <4038E9A5.2090601@gnu.org> (raw)
In-Reply-To: <200402202323.i1KNNaL4027099@elgar.kettenis.dyndns.org>


> Andrew, I think that this case is completely broken.  The frame chain
> isn't properly terminated.  The clone(2) system call that has created
> this thread tries to mark frame #3 as the outermost frame by clearing
> %rbp.  However, since most amd64 code doesn't use the frame pointer,
> this is pointless; GDB doesn't look at it.  The fact that you're
> seeing a zero PC here is merely accidental; it just happens to be that
> (%rsp) contains zero.  Therefore I don't think we should consider a
> zero PC as a marker for the end of the frame chain.
> 
> The Linux folks should add proper CFI to the implementation of
> close(2) in glibc.  A DW_CFA_def_cfa rule that sets the CFA to %rbp
> should do the trick.

clone(2)?  How come the trad unwind code doesn't recover?

Thinking about it, the test would stop this backtrace:

	sigsegv_handler
	<signal trampoline>
	"null"
	foo (which called "null")
	main

is this tested anywhere?

Andrew




  reply	other threads:[~2004-02-22 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-20 21:27 Andrew Cagney
2004-02-20 23:23 ` Mark Kettenis
2004-02-22 17:40   ` Andrew Cagney [this message]
2004-02-22 21:10     ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4038E9A5.2090601@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox