From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16997 invoked by alias); 14 Feb 2004 16:46:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16990 invoked from network); 14 Feb 2004 16:46:14 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 14 Feb 2004 16:46:14 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 036032B97; Sat, 14 Feb 2004 11:46:12 -0500 (EST) Message-ID: <402E50D4.6050409@gnu.org> Date: Sat, 14 Feb 2004 16:46:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [obish] Delete dead deprecated functions Content-Type: multipart/mixed; boundary="------------000502050609060908010407" X-SW-Source: 2004-02/txt/msg00367.txt.bz2 This is a multi-part message in MIME format. --------------000502050609060908010407 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 125 Hello, None of these architecture methods are defiend, and the frame methods aren't used. All deleted. committed, Andrew --------------000502050609060908010407 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 8699 2004-02-14 Andrew Cagney * gdbarch.sh (DEPRECATED_EXTRA_STACK_ALIGNMENT_NEEDED): Delete. (DEPRECATED_CALL_DUMMY_STACK_ADJUST): Delete. (DEPRECATED_CALL_DUMMY_ADDRESS): Delete. * gdbarch.h, gdbarch.c: Re-generate. * frame.c (deprecated_get_next_frame_hack): Delete function. * frame.h (deprecated_get_next_frame_hack): Delete declaration. * blockframe.c (deprecated_pc_in_call_dummy_at_entry_point): Update. * infcall.c (call_function_by_hand): Update. Index: doc/ChangeLog 2004-02-14 Andrew Cagney * gdbint.texinfo (Target Architecture Definition): Delete description of DEPRECATED_CALL_DUMMY_STACK_ADJUST. Index: blockframe.c =================================================================== RCS file: /cvs/src/src/gdb/blockframe.c,v retrieving revision 1.89 diff -u -r1.89 blockframe.c --- blockframe.c 12 Feb 2004 16:52:45 -0000 1.89 +++ blockframe.c 14 Feb 2004 16:36:20 -0000 @@ -599,8 +599,6 @@ CORE_ADDR frame_address) { CORE_ADDR addr = entry_point_address (); - if (DEPRECATED_CALL_DUMMY_ADDRESS_P ()) - addr = DEPRECATED_CALL_DUMMY_ADDRESS (); return ((pc) >= addr && (pc) <= (addr + DECR_PC_AFTER_BREAK)); } Index: frame.c =================================================================== RCS file: /cvs/src/src/gdb/frame.c,v retrieving revision 1.160 diff -u -r1.160 frame.c --- frame.c 12 Feb 2004 00:17:52 -0000 1.160 +++ frame.c 14 Feb 2004 16:37:00 -0000 @@ -1227,12 +1227,6 @@ return NULL; } -struct frame_info * -deprecated_get_next_frame_hack (struct frame_info *this_frame) -{ - return this_frame->next; -} - /* Flush the entire frame cache. */ void Index: frame.h =================================================================== RCS file: /cvs/src/src/gdb/frame.h,v retrieving revision 1.117 diff -u -r1.117 frame.h --- frame.h 12 Feb 2004 00:17:53 -0000 1.117 +++ frame.h 14 Feb 2004 16:37:07 -0000 @@ -222,13 +222,6 @@ extern struct frame_info *get_prev_frame (struct frame_info *); extern struct frame_info *get_next_frame (struct frame_info *); -/* Given a FRAME, return the true next (more inner, younger) frame. - This one exposes the sentinel frame and, hence, never returns NULL. - It is here strictly to help old targets in their migration path to - the new frame code - the new code requires the NEXT, and not THIS - frame. */ -extern struct frame_info *deprecated_get_next_frame_hack (struct frame_info *); - /* Given a frame's ID, relocate the frame. Returns NULL if the frame is not found. */ extern struct frame_info *frame_find_by_id (struct frame_id id); Index: gdbarch.sh =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.sh,v retrieving revision 1.296 diff -u -r1.296 gdbarch.sh --- gdbarch.sh 12 Feb 2004 16:52:45 -0000 1.296 +++ gdbarch.sh 14 Feb 2004 16:38:00 -0000 @@ -527,7 +527,6 @@ # DEPRECATED_REGISTER_SIZE can be deleted. v::DEPRECATED_REGISTER_SIZE:int:deprecated_register_size v::CALL_DUMMY_LOCATION:int:call_dummy_location:::::AT_ENTRY_POINT::0 -F::DEPRECATED_CALL_DUMMY_ADDRESS:CORE_ADDR:deprecated_call_dummy_address:void # DEPRECATED_CALL_DUMMY_START_OFFSET can be deleted. v::DEPRECATED_CALL_DUMMY_START_OFFSET:CORE_ADDR:deprecated_call_dummy_start_offset # DEPRECATED_CALL_DUMMY_BREAKPOINT_OFFSET can be deleted. @@ -538,8 +537,6 @@ v::DEPRECATED_CALL_DUMMY_WORDS:LONGEST *:deprecated_call_dummy_words::::0:legacy_call_dummy_words::0:0x%08lx # Implement PUSH_DUMMY_CALL, then delete DEPRECATED_SIZEOF_CALL_DUMMY_WORDS. v::DEPRECATED_SIZEOF_CALL_DUMMY_WORDS:int:deprecated_sizeof_call_dummy_words::::0:legacy_sizeof_call_dummy_words::0 -# Implement PUSH_DUMMY_CALL, then delete DEPRECATED_CALL_DUMMY_STACK_ADJUST. -V:2:DEPRECATED_CALL_DUMMY_STACK_ADJUST:int:deprecated_call_dummy_stack_adjust # DEPRECATED_FIX_CALL_DUMMY can be deleted. For the SPARC, implement # PUSH_DUMMY_CODE and set CALL_DUMMY_LOCATION to ON_STACK. F::DEPRECATED_FIX_CALL_DUMMY:void:deprecated_fix_call_dummy:char *dummy, CORE_ADDR pc, CORE_ADDR fun, int nargs, struct value **args, struct type *type, int gcc_p:dummy, pc, fun, nargs, args, type, gcc_p @@ -547,9 +544,6 @@ M::PUSH_DUMMY_CODE:CORE_ADDR:push_dummy_code:CORE_ADDR sp, CORE_ADDR funaddr, int using_gcc, struct value **args, int nargs, struct type *value_type, CORE_ADDR *real_pc, CORE_ADDR *bp_addr:sp, funaddr, using_gcc, args, nargs, value_type, real_pc, bp_addr # Implement PUSH_DUMMY_CALL, then delete DEPRECATED_PUSH_DUMMY_FRAME. F:2:DEPRECATED_PUSH_DUMMY_FRAME:void:deprecated_push_dummy_frame:void:- -# Implement PUSH_DUMMY_CALL, then delete -# DEPRECATED_EXTRA_STACK_ALIGNMENT_NEEDED. -v:2:DEPRECATED_EXTRA_STACK_ALIGNMENT_NEEDED:int:deprecated_extra_stack_alignment_needed::::0:0::0::: F:2:DEPRECATED_DO_REGISTERS_INFO:void:deprecated_do_registers_info:int reg_nr, int fpregs:reg_nr, fpregs m:2:PRINT_REGISTERS_INFO:void:print_registers_info:struct ui_file *file, struct frame_info *frame, int regnum, int all:file, frame, regnum, all:::default_print_registers_info::0 Index: infcall.c =================================================================== RCS file: /cvs/src/src/gdb/infcall.c,v retrieving revision 1.36 diff -u -r1.36 infcall.c --- infcall.c 22 Nov 2003 22:15:23 -0000 1.36 +++ infcall.c 14 Feb 2004 16:38:12 -0000 @@ -559,9 +559,6 @@ } real_pc = funaddr; dummy_addr = entry_point_address (); - if (DEPRECATED_CALL_DUMMY_ADDRESS_P ()) - /* Override it. */ - dummy_addr = DEPRECATED_CALL_DUMMY_ADDRESS (); /* Make certain that the address points at real code, and not a function descriptor. */ dummy_addr = gdbarch_convert_from_func_ptr_addr (current_gdbarch, @@ -763,31 +760,6 @@ } } - /* elz: on HPPA no need for this extra alignment, maybe it is needed - on other architectures. This is because all the alignment is - taken care of in the above code (ifdef DEPRECATED_REG_STRUCT_HAS_ADDR) - and in hppa_push_arguments */ - /* NOTE: cagney/2003-03-24: The below code is very broken. Given an - odd sized parameter the below will mis-align the stack. As was - suggested back in '96, better to let PUSH_ARGUMENTS handle it. */ - if (DEPRECATED_EXTRA_STACK_ALIGNMENT_NEEDED) - { - /* MVS 11/22/96: I think at least some of this stack_align code - is really broken. Better to let push_dummy_call() adjust the - stack in a target-defined manner. */ - if (DEPRECATED_STACK_ALIGN_P () && INNER_THAN (1, 2)) - { - /* If stack grows down, we must leave a hole at the top. */ - int len = 0; - int i; - for (i = nargs - 1; i >= 0; i--) - len += TYPE_LENGTH (VALUE_ENCLOSING_TYPE (args[i])); - if (DEPRECATED_CALL_DUMMY_STACK_ADJUST_P ()) - len += DEPRECATED_CALL_DUMMY_STACK_ADJUST; - sp -= DEPRECATED_STACK_ALIGN (len) - len; - } - } - /* Create the dummy stack frame. Pass in the call dummy address as, presumably, the ABI code knows where, in the call dummy, the return address should be pointed. */ @@ -833,22 +805,8 @@ { /* If stack grows up, we must leave a hole at the bottom, note that sp already has been advanced for the arguments! */ - if (DEPRECATED_CALL_DUMMY_STACK_ADJUST_P ()) - sp += DEPRECATED_CALL_DUMMY_STACK_ADJUST; sp = DEPRECATED_STACK_ALIGN (sp); } - -/* XXX This seems wrong. For stacks that grow down we shouldn't do - anything here! */ - /* MVS 11/22/96: I think at least some of this stack_align code is - really broken. Better to let PUSH_ARGUMENTS adjust the stack in - a target-defined manner. */ - if (DEPRECATED_CALL_DUMMY_STACK_ADJUST_P ()) - if (INNER_THAN (1, 2)) - { - /* stack grows downward */ - sp -= DEPRECATED_CALL_DUMMY_STACK_ADJUST; - } /* Store the address at which the structure is supposed to be written. */ Index: doc/gdbint.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v retrieving revision 1.185 diff -u -r1.185 gdbint.texinfo --- doc/gdbint.texinfo 12 Feb 2004 17:46:40 -0000 1.185 +++ doc/gdbint.texinfo 14 Feb 2004 16:40:01 -0000 @@ -3077,12 +3077,6 @@ This method has been replaced by @code{push_dummy_code} (@pxref{push_dummy_code}). -@item DEPRECATED_CALL_DUMMY_STACK_ADJUST -@findex DEPRECATED_CALL_DUMMY_STACK_ADJUST -Stack adjustment needed when performing an inferior function call. This -function is no longer needed. @xref{push_dummy_call}, which can handle -all alignment directly. - @item CANNOT_FETCH_REGISTER (@var{regno}) @findex CANNOT_FETCH_REGISTER A C expression that should be nonzero if @var{regno} cannot be fetched --------------000502050609060908010407--