From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13596 invoked by alias); 12 Feb 2004 23:52:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13589 invoked from network); 12 Feb 2004 23:52:41 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 12 Feb 2004 23:52:41 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i1CNqeb07300 for ; Thu, 12 Feb 2004 18:52:40 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1CNqdM13364; Thu, 12 Feb 2004 18:52:39 -0500 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i1CNqcX03632; Thu, 12 Feb 2004 15:52:38 -0800 Message-ID: <402C11C6.1090404@redhat.com> Date: Thu, 12 Feb 2004 23:52:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 MIME-Version: 1.0 To: Joern Rennecke CC: Joern Rennecke , gdb-patches@sources.redhat.com Subject: Re: [RFA] sh-sim loose ends References: <200402122239.i1CMdJK12072@linsvr1.uk.superh.com> In-Reply-To: <200402122239.i1CMdJK12072@linsvr1.uk.superh.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00334.txt.bz2 Joern Rennecke wrote: >> * gencode.c (movt): Modifies R[n]; call 'L' macro. > > > That doesn't make sense, 'L' simulates the data read memory latency of an > SH[123]. movt doesn't incur such a latency. Hmmm? I thought 'L' was for registers, and 'MA' was for memory access. This is the only instruction that modifies a gpr but doesn't call 'L'. Figured it was an oversight. >> (trapa): Factor out duplicate variable 'imm' (same as 'i'). > > OK. But I don't see why you need the cast to long. I guess I don't. >> (sleep, trapa, ppi): Use SET_NIP to modify nip. > > > I don't see any need for this. RAISE_EXCEPTION already clears > saved_state.asregs.insn_end , so that takes care of the > exceptions that might arise during sleep. > For trapa, that leaves just the possibility that we fail to miss a > loop bound that is set to somewhere inside a profiler trap; I think > you deserve whatever you get when you do that. > Similar for ppi; are you afrais that we fail to miss a loop bound > that is set to field_b of a ppi insn? Actually I was just going for consistancy (everywhere else that modifies nip uses SET_NIP). I'll gladly drop this part of the patch if you don't like it.