From: Jeff Johnston <jjohnstn@redhat.com>
To: Eli Zaretskii <eliz@elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC]: new set breakpoint pending and show breakpoint pending commands
Date: Wed, 11 Feb 2004 22:10:00 -0000 [thread overview]
Message-ID: <402AA84F.7040705@redhat.com> (raw)
In-Reply-To: <uptcmp270.fsf@elta.co.il>
Eli Zaretskii wrote:
>>Date: Tue, 10 Feb 2004 19:18:41 -0500
>>From: Jeff Johnston <jjohnstn@redhat.com>
>>
>>I have included a doc patch but will wait on posting a change to pending.exp
>>until everyone is ok with the interface. A change is not required to make
>>pending.exp work, it would just exercise the new functionality. I have tested
>>the new settings manually.
>>
>>Ok?
>
>
> Thanks. A few minor comments about the documentation patch:
>
>
>>+If a specified breakpoint location cannot be found, it may due to the fact
>
> ^^^
> I think there's a "be" missing at the spot I marked.
>
Arrr, there be.
>
>>+that the location is in a shared library that is yet to be loaded. In such
>>+a case, you may want @value{GDBN} to create a special breakpoint (known as
>>+a pending breakpoint) that
>
>
> Please put "pending breakpoint", just this once, in @dfn{}, so that it
> stands out. (This is generally a good practice when introducing new
> terminology.)
>
Done.
>
>> When a breakpoint location is unrecognized,
>>+you are queried to see if a pending breakpoint should be created.
>
>
> I'd rephrase this slightly:
>
> When @value{GDBN} cannot find the breakpoint location, it queries
> you whether a pending breakpoint should be created.
>
Done.
> Otherwise, it can go in when the code patch is approved.
>
>
Thanks.
next prev parent reply other threads:[~2004-02-11 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-11 0:18 Jeff Johnston
2004-02-11 6:19 ` Eli Zaretskii
2004-02-11 22:10 ` Jeff Johnston [this message]
2004-02-19 22:38 ` Jeff Johnston
2004-02-26 20:06 ` Jeff Johnston
2004-02-26 20:24 ` Andrew Cagney
2004-02-26 23:47 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=402AA84F.7040705@redhat.com \
--to=jjohnstn@redhat.com \
--cc=eliz@elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox