From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-30542-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 5303 invoked by alias); 10 Feb 2004 18:30:17 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5296 invoked from network); 10 Feb 2004 18:30:16 -0000
Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.20)
  by sources.redhat.com with SMTP; 10 Feb 2004 18:30:16 -0000
Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72])
	by touchme.toronto.redhat.com (Postfix) with ESMTP
	id AEC71800195; Tue, 10 Feb 2004 13:30:15 -0500 (EST)
Message-ID: <40292337.3090907@redhat.com>
Date: Tue, 10 Feb 2004 18:30:00 -0000
From: Jeff Johnston <jjohnstn@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1
MIME-Version: 1.0
To: Eli Zaretskii <eliz@elta.co.il>
Cc: Daniel Jacobowitz <drow@mvista.com>,
	gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Patch for ia64-tdep.c to cross-compile
References: <40282283.4090904@redhat.com> <20040210025527.GA16979@nevyn.them.org> <ullnbzc0y.fsf@elta.co.il>
In-Reply-To: <ullnbzc0y.fsf@elta.co.il>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-02/txt/msg00242.txt.bz2

Eli Zaretskii wrote:
>>Date: Mon, 9 Feb 2004 21:55:27 -0500
>>From: Daniel Jacobowitz <drow@mvista.com>
>>
>>>2004-02-09  Jeff Johnston  <jjohnstn@redhat.com>
>>>
>>>        * ia64-tdep.c (ia64_frame_this_id): Fix tracing print statement
>>>        to use paddr functions to format ia64 addresses and long values..
>>>        (ia64_frame_prev_register, ia64_sigtramp_frame_this_id): Ditto.
>>>        (ia64_sigtramp_frame_prev_register, ia64_access_reg): Ditto.
>>>        (get_kernel_table, ia64_find_proc_info_x): Ditto.
>>>        (ia64_get_dyn_info_list, ia64_libunwind_this_frame_id): Ditto.
>>>        (ia64_libunwind_frame_prev_register, ia64_unwind_dummy_id): Ditto.
>>>
>>
>>I think this patch is "obvious"
> 
> 
> If this is an obvious patch, shouldn't we have some coding rule
> somewhere to cover it?  It certainly isn't obvious out of the GDB
> context, i.e. not a standard coding practice.
> 
>

Eli,

   Do you want me to hold off on checking this in or do you just wish to discuss 
whether such a patch should be marked as obvious in the future?

-- Jeff J.