From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1557 invoked by alias); 7 Feb 2004 23:48:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1549 invoked from network); 7 Feb 2004 23:48:56 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 7 Feb 2004 23:48:56 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 8E7492B92; Sat, 7 Feb 2004 18:48:47 -0500 (EST) Message-ID: <4025795F.9080308@gnu.org> Date: Sat, 07 Feb 2004 23:48:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com, weigand@informatik.uni-erlangen.de Subject: Re: [PATCH/RFC] Per-architecture DWARF CFI register state initialization hooks References: <200402072237.i17Mbqae011375@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00160.txt.bz2 > Here's my proposal for the per-architecture DWARF CFI register state > initialization hooks needed for S/390, and others. This is a RFC, > since I'm not entirely confident whether my approach is acceptable. I > chose to implement this using per-architecture data instead of adding > a function to the architecture vector. I think it is cleaner since it > keeps things localized and modular, and the architecture vector is big > enough as it stands. Yes. Technical nit though - I think it is still better to have a local data struct and store the value in there. Andrew