Re: [PATCH v3 2/5] gdb: remove target_ops::commit_resume implementation in record-{btrace,full}.c

Pedro Alves
2021-01-08T15:43:59Z

On 08/01/21 04:17, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@efficios.com>
>
> The previous patch made the commit_resume implementations in the record
> targets unnecessary, as the remote target's commit_resume implementation
> won't commit-resume threads for which it didn't see a resume. This
> patch removes them.
>
> gdb/ChangeLog:
>
> * record-btrace.c (class record_btrace_target):
> (record_btrace_target::commit_resume):
> * record-full.c (class record_full_target):
> (record_full_target::commit_resume):

Incomplete entry.

Otherwise LGTM. I like how these two patches result in clearer code. Nice.