From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MSvpDk99+F9YMgAAWB0awg (envelope-from ) for ; Fri, 08 Jan 2021 10:42:07 -0500 Received: by simark.ca (Postfix, from userid 112) id 2C97F1E99A; Fri, 8 Jan 2021 10:42:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C16A61E4F4 for ; Fri, 8 Jan 2021 10:42:06 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 490D13854838; Fri, 8 Jan 2021 15:42:06 +0000 (GMT) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by sourceware.org (Postfix) with ESMTPS id 6F6CA3854838 for ; Fri, 8 Jan 2021 15:42:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6F6CA3854838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f51.google.com with SMTP id g25so6954098wmh.1 for ; Fri, 08 Jan 2021 07:42:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G/S4CiUKMywkKkhIA+uE1zVXrvWFXmFBmxy+bGrhYJc=; b=jpKdGTjT0p5tl8s5G01oVLdLBlwJgP5W2UKRrw7+uE+B7lDy1qOBxhj7zBp6Py0J83 zeVFlAtujc1UAiWyuvZFIPBfKtJggdfYCswkTXNRs+iPprp4n+ujxKyb2twFxQ/YGC9K UK0O9j8iIwGI+FBOl0+9lPm2pFImCzpXxWDrKgp+MjNefR04MEJgfyVTByiDESrWuTyo a7HoXJc0YiRLw6N6J/lwSeqzGMtlhXcKdCzccGPe6N2X6a+RSPa01Jd4hbRCecUkrAdu xlsZEqKBbPxyUVUHcND1UUaOpNp+c9yX+vchVsMPnmmcWZRUZZk8X7iyUSBPBSxd4/qd +DZg== X-Gm-Message-State: AOAM532VCAOvAYHa7xOYV/i2MuvVFrfKsp+LKEkFKwclSfNPDtMjdN+I GPQP4lqXKlSdWE3FM958eT4= X-Google-Smtp-Source: ABdhPJycMTWXy7RPpuLlCj3pcSgFt2LFPWW9+SrFvt5bkJwR4QQKLmqJh5dhhB9Kw81INkV4EWFu8g== X-Received: by 2002:a1c:9a57:: with SMTP id c84mr3444252wme.183.1610120521544; Fri, 08 Jan 2021 07:42:01 -0800 (PST) Received: from ?IPv6:2001:8a0:f91f:e900:1d90:d745:3c32:c159? ([2001:8a0:f91f:e900:1d90:d745:3c32:c159]) by smtp.gmail.com with ESMTPSA id s13sm11846463wmj.28.2021.01.08.07.42.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jan 2021 07:42:00 -0800 (PST) Subject: Re: [PATCH v3 1/5] gdb: make the remote target track its own thread resume state From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210108041734.3873826-1-simon.marchi@polymtl.ca> <20210108041734.3873826-2-simon.marchi@polymtl.ca> Message-ID: <40239345-48c3-1015-7ee3-e80489ccdce6@palves.net> Date: Fri, 8 Jan 2021 15:41:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210108041734.3873826-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, This patch LGTM. A couple tiny issue below. > gdb/ChangeLog: > > * remote.c (enum class resume_state): New. > (struct resumed_pending_vcont_info): New. > (struct remote_thread_info) set_resumed_pending_vcont, resumed_pending_vcont_info, > set_resumed, m_resume_state, m_resumed_pending_vcont_info>: > New. > : Remove. > (remote_target::remote_add_thread): Adjust. > (remote_target::process_initial_stop_replies): Adjust. > (remote_target::resume): Adjust. > (remote_target::commit_resume): Rely on state in > remote_thread_info and not on tp->executing. > (remote_target::process_stop_reply): Adjust. Mind spaces vs tabs in the ChangeLog entry. > +/* Information about a thread's pending vCont-resume. Used when a thread is in > + the remote_resume_state::RESUMED_PENDING_VCONT state. remote_target::resume > + stores this information which is them picked up by them -> then That's it. :-)