From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3796 invoked by alias); 6 Feb 2004 01:09:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3789 invoked by uid 0); 6 Feb 2004 01:09:45 -0000 Resent-Message-ID: <20040206010945.3788.qmail@sources.redhat.com> Received: (qmail 30520 invoked from network); 5 Feb 2004 23:47:26 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 5 Feb 2004 23:47:26 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i15NlPb22405 for ; Thu, 5 Feb 2004 18:47:25 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i15NlNM26618; Thu, 5 Feb 2004 18:47:23 -0500 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i15NlMX18254; Thu, 5 Feb 2004 15:47:22 -0800 Message-ID: <4022D60A.5020905@redhat.com> Date: Fri, 06 Feb 2004 01:09:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 MIME-Version: 1.0 To: Joern Rennecke CC: joern.rennecke@superh.com, gdb-patches@sources.redhat.com Subject: [RFA] sh-sim: thislock/prevlock tweak References: <200312201305.hBKD5MHZ001588@meolyon.local> In-Reply-To: <200312201305.hBKD5MHZ001588@meolyon.local> Content-Type: multipart/mixed; boundary="------------000109040209070906050002" Resent-From: root@sourceware.org Resent-Date: Fri, 6 Feb 2004 01:09:45 +0000 Resent-To: gdb-patches@sources.redhat.com X-SW-Source: 2004-02/txt/msg00114.txt.bz2 This is a multi-part message in MIME format. --------------000109040209070906050002 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 233 Joern, I don't fully understand this code, but it looks to me as if this minor change is needed. Most other instructions appear to call the macro "L()" for the register that was explicitly the target of the instruction. Michael --------------000109040209070906050002 Content-Type: text/plain; name="tmp" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="tmp" Content-length: 1510 2004-02-05 Michael Snyder * gencode.c (movua.l): Set thislock to 0, not n. Index: gencode.c =================================================================== RCS file: /cvs/src/src/sim/sh/gencode.c,v retrieving revision 1.26 diff -p -r1.26 gencode.c *** gencode.c 27 Jan 2004 23:30:01 -0000 1.26 --- gencode.c 5 Feb 2004 23:40:27 -0000 *************** op tab[] = *** 869,875 **** "MA (1);", "R[0] = (RBAT (regn) << 24) + (RBAT (regn + 1) << 16) + ", " (RBAT (regn + 2) << 8) + RBAT (regn + 3);", ! "L (n);", }, { "0n", "n", "movua.l @+,R0", "0100nnnn11101001", "int regn = R[n];", --- 869,875 ---- "MA (1);", "R[0] = (RBAT (regn) << 24) + (RBAT (regn + 1) << 16) + ", " (RBAT (regn + 2) << 8) + RBAT (regn + 3);", ! "L (0);", }, { "0n", "n", "movua.l @+,R0", "0100nnnn11101001", "int regn = R[n];", *************** op tab[] = *** 877,883 **** "R[0] = (RBAT (regn) << 24) + (RBAT (regn + 1) << 16) + ", " (RBAT (regn + 2) << 8) + RBAT (regn + 3);", "R[n] += 4;", ! "L (n);", }, { "", "mn", "mul.l ,", "0000nnnnmmmm0111", "MACL = ((int) R[n]) * ((int) R[m]);", --- 877,883 ---- "R[0] = (RBAT (regn) << 24) + (RBAT (regn + 1) << 16) + ", " (RBAT (regn + 2) << 8) + RBAT (regn + 3);", "R[n] += 4;", ! "L (0);", }, { "", "mn", "mul.l ,", "0000nnnnmmmm0111", "MACL = ((int) R[n]) * ((int) R[m]);", --------------000109040209070906050002--