From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25966 invoked by alias); 27 Jan 2004 20:28:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25952 invoked from network); 27 Jan 2004 20:28:13 -0000 Received: from unknown (HELO localhost.redhat.com) (66.187.230.200) by sources.redhat.com with SMTP; 27 Jan 2004 20:28:13 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3B06F2B93; Tue, 27 Jan 2004 12:39:17 -0500 (EST) Message-ID: <4016A245.6030001@gnu.org> Date: Tue, 27 Jan 2004 20:28:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: RFA (?) Annotate Level 3 patch References: <16176.3560.65649.7079@nick.uklinux.net> Content-Type: multipart/mixed; boundary="------------040104090203000704090007" X-SW-Source: 2004-01/txt/msg00702.txt.bz2 This is a multi-part message in MIME format. --------------040104090203000704090007 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 298 (Working through the old ones :-() Nick, Can you post a log with/with-out this patch to illustrate what's happening. You're right - emacs should see "stopped" first but there might be a better long-term way to do this. I suspect this will mean playing with the print-stop-reason code. Andrew --------------040104090203000704090007 Content-Type: message/rfc822; name="mailbox-message://ac131313@movemail/fsf/gdb/patches#125619" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mailbox-message://ac131313@movemail/fsf/gdb/patches#125619" Content-length: 3645 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: cagney@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 292EF2B7F for ; Wed, 6 Aug 2003 22:05:27 -0400 (EDT) Envelope-to: cagney@gnu.org Delivery-date: Tue, 05 Aug 2003 16:10:26 -0400 Received: from fencepost.gnu.org by localhost with IMAP (fetchmail-6.2.1) for cagney@localhost (single-drop); Wed, 06 Aug 2003 22:05:27 -0400 (EDT) Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.20) id 19k88Y-0004gf-1z for cagney@gnu.org; Tue, 05 Aug 2003 16:10:26 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19k88f-0001Uh-Hq for cagney@gnu.org; Tue, 05 Aug 2003 16:11:04 -0400 Received: from [67.72.78.213] (helo=sources.redhat.com) by monty-python.gnu.org with smtp (Exim 4.20) id 19k88e-0001Tx-Ih for cagney@gnu.org; Tue, 05 Aug 2003 16:10:32 -0400 Received: (qmail 13406 invoked by alias); 5 Aug 2003 20:10:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Delivered-To: mailing list gdb-patches@sources.redhat.com Received: (qmail 13390 invoked from network); 5 Aug 2003 20:10:24 -0000 Received: from unknown (HELO nick.uklinux.net) (194.247.48.13) by sources.redhat.com with SMTP; 5 Aug 2003 20:10:24 -0000 Received: by nick.uklinux.net (Postfix, from userid 501) id 96BD475FDE; Tue, 5 Aug 2003 21:04:56 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16176.3560.65649.7079@nick.uklinux.net> Date: Tue, 5 Aug 2003 21:04:56 +0100 To: gdb-patches@sources.redhat.com Subject: RFA (?) Annotate Level 3 patch X-Spam-Status: No, hits=-0.5 required=5.0 tests=PATCH_UNIFIED_DIFF version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) Content-length: 1216 The annotation frame-begin is not needed, per se, by Emacs (gdb-ui.el) but it is used to determine that the I/O for the subprocess is now GDB, not the program being debugged i.e as a stopped annotation. In many cases there is another annotation e.g breakpoint to tell Emacs this. However, in some cases, e.g after `finish' or `return', frame-begin is the first `stopping' annotation that GDB issues before printing (out frame details). So I propose the patch below. It means that the stopped annotation gets printed twice but that doesn't matter to Emacs. It's not elegant but, hey, it works! I think Emacs is the only application that is interested in level 3 annotations so could "-gnuemacs" be made an alias option for "-annotate=3"? >From GDB's point of view this would discourage new applications form using it. From Emacs point of view, it would legitimise changes that we would wish to make. Nick --- annotate.c.~1.5.60.1.~ 2003-07-29 14:35:47.000000000 +0100 +++ annotate.c 2003-08-04 19:44:02.000000000 +0100 @@ -436,6 +436,7 @@ print_address_numeric (pc, 0, gdb_stdout); printf_filtered ("\n"); } + if (annotation_level == 3) printf_filtered ("\n\032\032stopped\n"); } void --------------040104090203000704090007--