Re: [PATCH v2 03/47] infrun: Remove unnecessary currently_stepping call

Kevin Buettner
2025-05-21T19:44:47Z

On Mon, 19 May 2025 14:22:24 +0100
Pedro Alves <pedro@palves.net> wrote:

> There's one unnecessary check for currently_stepping in
> handle_signal_stop that can be removed. It is unnecessary because
> currently_stepping is only ever called if
> ecs->event_thread->control.trap_expected is true, and then if it is
> true, then currently_stepping always returns true too.

After looking at the definition of currently_stepping(), I agree
with your reasoning (and your patch).

Approved-by: Kevin Buettner <kevinb@redhat.com>