Re: [PATCH v2 41/47] Windows gdb: Watchpoints while running (internal vs external stops)

Tom Tromey
2025-05-30T20:50:50Z

>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> Teach the Windows target to temporarily pause all threads when we
Pedro> change the debug registers for a watchpoint. Implements the same
Pedro> logic as Linux uses:
[...]

I doubt I'll be able to understand this particular patch without
debugging it myself or something, but I read through it and didn't see
anything obviously out of wack.

Pedro> and DR7. Defering the actualy writes to ::wait avoids a bunch of

s/actualy/actual/

Pedro> +static void
Pedro> +debug_registers_changed_all_threads ()
Pedro> +{
Pedro> + auto *win_tgt = static_cast<windows_nat_target *> (get_native_target ());

Probably checked_static_cast?

Reviewed-By: Tom Tromey <tom@tromey.com>

Tom