Re: [PATCH v2 14/47] Windows gdb: Simplify windows_nat_target::wait

Tom Tromey
2025-05-28T19:17:01Z

>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> This patch changes things a bit so that the code is more obvious:

Pedro> - look at the status kind, instead of ptid_t.

Pedro> - add an explicit early return case for no-event.

Pedro> - add an explicit case for TARGET_WAITKIND_SPURIOUS.

Pedro> - with those, we no longer need to handle the case of find_thread not
Pedro> finding a thread, so we can drop one indentation level.

Thanks for cleaning this up. I think this is ok. It's hard to be
really sure in this area, I feel like I've had multiple rounds of
changes here in the past.

Approved-By: Tom Tromey <tom@tromey.com>

Tom