From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id biJ5CcSST2pCjAAAWB0awg (envelope-from ) for ; Thu, 09 Jul 2026 08:23:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1783599812; bh=tCvfTD4d87phjegep/keoBxcSJdwetO9YK+IBVQmU28=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BZ0xzsVjHFnd2cmE6aSCzdlFGb1ytIvMGsPC/9lozdbuSStTGZlAOjY9DbgDTCmS+ O9XeVvsIt3DiUxVAqn6vvC67h1EnmpqZJ5N//RPby4F2J4lpdDU3mGmjbEfGh2iae1 CofjWIHiuSYLDo6D6iyGrJ9PxHRGWZBmztJAgIMM= Received: by simark.ca (Postfix, from userid 112) id 183291E098; Thu, 09 Jul 2026 08:23:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sXRiQhZI; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 77FE11E070 for ; Thu, 09 Jul 2026 08:23:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F3EE14BA2E21 for ; Thu, 9 Jul 2026 12:23:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3EE14BA2E21 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sXRiQhZI Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E12094BA2E09 for ; Thu, 9 Jul 2026 12:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E12094BA2E09 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E12094BA2E09 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783599787; cv=none; b=CiJLyhmdIq5QH0DvSXKS8IllP/ABpKKk8m96g1nihvH1UCD/l0LVQvcNf7NRTXoLS1y9T4r4N4XcZbg7dgn4zsDmkL2tR/WcM2mmdkrt00Ij5YTtvrZkoI1Hkbj35FnFWs1Nt+H1pN1YakDbYC3KL7kb4H2f+9epuh6rDfMAro8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783599787; c=relaxed/simple; bh=tCvfTD4d87phjegep/keoBxcSJdwetO9YK+IBVQmU28=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GT3SWgdR2TxkoxHY0irEcuf+U8b18Bel3VYYQTurY5JfVUAjWBHuWeIcgY9nWSTERX+QqBX2YczgqiYq1ZmvJqevjAJYeB7u0GkUXhU0OnzEhW3kQHMxaK02SK0bDlSAkOmTQ4JdL8Qsl/ZrAkjPL8spsBMTW9bpc4CJ25E4Yv8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=sXRiQhZI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E12094BA2E09 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1783599785; bh=tCvfTD4d87phjegep/keoBxcSJdwetO9YK+IBVQmU28=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sXRiQhZILCp0QTZGPuygsXKGPWtZyFuE/50cXFcsY6rFQzjbo8SmRyAeTGePL2zH1 CEchxWjvIpWT2MAxp8jBH/0r3WTFnBZxXr00wcyNfAD3SRFG5IwBpEgSsz6LZYURJp mgFaabaLrZejAr/eurZVPN9Yn4OG58jyLNmhNPjE= Received: by simark.ca (Postfix) id 9EEC71E070; Thu, 09 Jul 2026 08:23:04 -0400 (EDT) Message-ID: <400ce145-7dbf-4e4a-a681-48ca86cf874e@simark.ca> Date: Thu, 9 Jul 2026 08:23:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 01/10] gdb/linux-tdep: change linux_fill_prpsinfo to return bool To: Thiago Jung Bauermann , Matthieu Longo Cc: gdb-patches@sourceware.org, Luis Machado , Luis Machado , Andrew Burgess , Yury Khrustalev , Pedro Alves , Tom Tromey References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-2-matthieu.longo@arm.com> <87se5s1xxf.fsf@linaro.org> Content-Language: en-US From: Simon Marchi In-Reply-To: <87se5s1xxf.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-07-09 02:26, Thiago Jung Bauermann wrote: > Hello Matthieu, > > Thank you for these patches. > > Matthieu Longo writes: > >> Change linux_fill_prpsinfo() to return a boolean instead of an integer, since >> it only reports success or failure. >> Replace the returned integer values 1 and 0 with true and false respectively. >> --- >> gdb/linux-tdep.c | 22 +++++++++++----------- >> 1 file changed, 11 insertions(+), 11 deletions(-) > > In his review of an analogous patch, Simon suggested that this kind of > change could be pushed as obvious: > > https://inbox.sourceware.org/gdb-patches/53a86cae-2927-49ec-83a2-22ff6526c0e6@simark.ca/ > > I would agree, but I don't know if that's a generally accepted view. Yeah, you still need to be careful, I did manage once to mess up and change a 0 into true or vice versa. Also, try to change comments that use 0/1, or "zero"/"non-zero" so they say true/false. I see you did it for comments inside the function, but the comment above the function also has thing that would need to be updated. > > In any case: > > Reviewed-by: Thiago Jung Bauermann With the comment updated: Approved-By: Simon Marchi Simon