From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19402 invoked by alias); 21 Jan 2004 23:12:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19390 invoked from network); 21 Jan 2004 23:12:30 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 21 Jan 2004 23:12:30 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 1EA65800195; Wed, 21 Jan 2004 18:12:30 -0500 (EST) Message-ID: <400F075D.7070904@redhat.com> Date: Wed, 21 Jan 2004 23:12:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: pending breakpoint support [2/3] References: <400EE920.4050705@redhat.com> <20040121222044.GB3324@nevyn.them.org> In-Reply-To: <20040121222044.GB3324@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00602.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Jan 21, 2004 at 04:03:28PM -0500, Jeff Johnston wrote: > >>The following makes changes to the testsuite to accomodate the pending >>breakpoint support. >>A new test case has been added to test pending breakpoint support. >> >>Ok to commit? > > > Needs a tweak. > > >>-gdb_test "b langs0" "Function \"langs0\" not defined\.|Breakpoint .* (deferred).*" \ >>- "break on nonexistent function in langs.exp" > > > This has an implicit "$gdb_prompt $" anchor. All of the following > cases need something similar; for the pending case that means you > should replace send_gdb "n\n" with, probably, gdb_test "n" "" "break > on...". > > >>+gdb_test_multiple "break pendfunc1" "set pending breakpoint" { >>+ -re ".*Make breakpoint pending.*$" { > > > Similarly, don't do that. As soon as expect's buffer is full, it will > try to match, and succeed; possibly leaving a pending $gdb_prompt for > another test to match, getting us hideously out of sync. Match > whatever prompt you > > > >>+ -re "Make breakpoint pending.*y or n. $" { >>+ send_gdb "n\n"; >>+ fail "setting breakpoint at $function" ; >>+ return 0 >>+ } > > > [in lib/gdb.exp] ditto. > Daniel, can you clarify this last comment. Is something wrong with the prompt test in the -re line or do you want me to change the send_gdb to be a gdb_test? -- Jeff J.