Thanks. I updated comments as asked. The revised patch has been checked in. -- Jeff J. Andrew Cagney wrote: > >> >> Ok, patch revised. >> >> I chose to add a new version of catch_exceptions() called >> catch_exceptions_with_msg() which saves a copy of the error message >> (if an error occurs) for the caller to manually output if desired. >> The copy needs to be freed by the caller once the message is no longer >> needed. >> >> I removed error_last_output() and created a new function >> error_output_message() which takes pre_print text plus a message and >> outputs to gdb_stderr. >> >> Any other problems or ok to commit? > > > Much nicer - that nasty message buffer is better confied to top.c - > thank. Just suggest more commentary here: > >> - throw_exception (RETURN_ERROR); >> + error_silent ("No source file named %s.", copy); > > before committing (elena's already oked it from memory). > > tks. > Andrew > > >