From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-29992-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1755 invoked by alias); 18 Jan 2004 18:51:24 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1740 invoked from network); 18 Jan 2004 18:51:22 -0000
Received: from unknown (HELO localhost.redhat.com) (65.49.4.239)
  by sources.redhat.com with SMTP; 18 Jan 2004 18:51:22 -0000
Received: from gnu.org (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 775322B8F; Sun, 18 Jan 2004 13:51:12 -0500 (EST)
Message-ID: <400AD5A0.7060900@gnu.org>
Date: Sun, 18 Jan 2004 18:51:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820
MIME-Version: 1.0
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix PR testsuite/1504
References: <200401181835.i0IIZcwu054181@elgar.kettenis.dyndns.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-01/txt/msg00477.txt.bz2

> Turns out there is an inconsistency between platforms in the error
> message one gets when reading from a bit of memory that isn't
> readable:
> 
> void
> memory_error (int status, CORE_ADDR memaddr)
> {
>   struct ui_file *tmp_stream = mem_fileopen ();
>   make_cleanup_ui_file_delete (tmp_stream);
> 
>   if (status == EIO)
>     {
>       /* Actually, address between memaddr and memaddr + len
>          was out of bounds. */
>       fprintf_unfiltered (tmp_stream, "Cannot access memory at address ");
>       print_address_numeric (memaddr, 1, tmp_stream);
>     }
>   else
>     {
>       fprintf_filtered (tmp_stream, "Error accessing memory address ");
>       print_address_numeric (memaddr, 1, tmp_stream);
>       fprintf_filtered (tmp_stream, ": %s.",
>                        safe_strerror (status));
>     }
> 
>   error_stream (tmp_stream);
> }
> 
> I wonder whether we should try to unify this.  In the meantime, this
> patch fixes the fall-out in the testsuite.

Yes, definitly.  Kfail instead - that would flush out those cases?

Andrew