From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66217 invoked by alias); 15 Jul 2018 19:46:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66161 invoked by uid 89); 15 Jul 2018 19:46:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Jul 2018 19:46:20 +0000 Received: by simark.ca (Postfix, from userid 112) id 59C001EF28; Sun, 15 Jul 2018 15:46:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531683978; bh=UrfW28Knkjfe+UAjeVF2z5eRGA4I2U59M7HeMkbsBXE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g8Hk0HTMoHN6NyoYA6PynFldhWRZ0/+HWX13aY187/txNa3//o7RhYBQ2VHNhw7gg 0N+T/cz/If9WGiY26P8E4V0tUSwxAj2OMgM9EKA1ZSu5+Caj0m7gPtJhQu72BAkNi6 NtrSFnKsO30G5I5V35kyopdoi4rJPg46wQNsSi5o= Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 7FD531E059; Sun, 15 Jul 2018 15:46:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531683977; bh=UrfW28Knkjfe+UAjeVF2z5eRGA4I2U59M7HeMkbsBXE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GYeW29FZBaGh+TxRLXXK0XeR794Myq5B05aAyo75gYiiNq7WCl0zrzXuXxtphi/yC hUla4K981e8SaRAGOli7meh/pNSQryZAe+PYw7TYbQcrAdncgNyAFfXs0koJE0pfgP NMHi/oeQBqoRjuHnWTkDYSR66hgbzTCU52FxPWUY= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 15 Jul 2018 19:46:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 38/42] Introduce legacy-buildsym.h In-Reply-To: <87lgac8hm7.fsf@tromey.com> References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-39-tom@tromey.com> <89126236-88df-d625-63f9-6cfac82b44a7@simark.ca> <87lgac8hm7.fsf@tromey.com> Message-ID: <4009c6a555e59ae88e7ded4ff306341a@simark.ca> X-Sender: simark@simark.ca User-Agent: Roundcube Webmail/1.3.6 X-SW-Source: 2018-07/txt/msg00470.txt.bz2 On 2018-07-15 14:43, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote: >>> This introduces a new header, legacy-buildsym.h, and changes all the >>> symbol readers to use it. The idea is to put the function-based >>> interface, that relies on the buildsym_compunit global, into a >>> separate header. Then when a symbol reader is updated to use the new >>> interface, it can simply not include legacy-buildsym.h, so it's easy >>> to be sure that the new API is used everywhere. > > Simon> Cool, good idea. I have two suggestions: > > Simon> - Name it buildsym-legacy.h, so that it will be ordered right > next to > Simon> buildsym.h in alphabetical lists. > Simon> - I would also create buildsym-legacy.c and move all the > corresponding > Simon> definitions there, including the buildsym_compunit global > variable. > Simon> I haven't actually tried it, maybe it's not possible and you > have > Simon> already tried it though. > > I did these. > I think I've made it through all the review comments. > I'm running the result through the buildbot again & then I will > re-submit it. I think due to the number of rebases and edits required > it will need another round of review. Sure. But if there are some patches that had no comments that can be pushed on their own, feel free to do so. It would reduce the size of v2 a bit. Simon