Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFC: Centralize DECR_PC_AFTER_BREAK handling from infrun
Date: Sat, 17 Jan 2004 22:39:00 -0000	[thread overview]
Message-ID: <4009B971.50803@gnu.org> (raw)
In-Reply-To: <20040117222007.GA23563@nevyn.them.org>

> The first, possibly most important step in cleaning up DECR_PC_AFTER_BREAK's
> tentacles.  This changes handle_inferior_event to fix the PC immediately,
> before doing anything else with it.  It removes the later decrements, but
> doesn't remove all the later workarounds for possibly undecremented PC
> values - that can come separately.
> 
> One case, HANDLE_NONSTEPPABLE_WATCHPOINTS and DECR_PC_AFTER_BREAK, is simply
> removed.  There are no targets using this combination, and if one is added,
> it's non-obvious whether a nonsteppable watchpoint really should be affected
> by DECR_PC_AFTER_BREAK.
> 
> A future cleanup will change bpstat_stop_status to only take a CORE_ADDR
> argument.  Also, I believe that both the tests for sigtramps and the use of
> deprecated_frame_update_pc_hack can go now, but I don't want to mix that in
> with this - esp. since I'm not sure how to test the former belief.

Build gdb with gcov and then run the testsuite, it will quickly point 
you at the "dead" code paths and hence how well it was really tested.

Otherwize, yow!

Andrew



  reply	other threads:[~2004-01-17 22:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-17 22:20 Daniel Jacobowitz
2004-01-17 22:39 ` Andrew Cagney [this message]
2004-01-17 23:04   ` Daniel Jacobowitz
2004-01-18  7:05 ` Eli Zaretskii
2004-01-18 15:19   ` Daniel Jacobowitz
2004-01-18 17:27     ` Eli Zaretskii
2004-01-18 18:01       ` Andrew Cagney
2004-01-18 19:08         ` Eli Zaretskii
2004-01-31 17:51       ` Daniel Jacobowitz
2004-01-31 17:49     ` Daniel Jacobowitz
2004-01-22 14:09 ` Andrew Cagney
2004-01-22 22:34   ` Daniel Jacobowitz
2004-01-31 19:19 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4009B971.50803@gnu.org \
    --to=cagney@gnu.org \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox