From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1257 invoked by alias); 17 Jan 2004 15:36:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1250 invoked from network); 17 Jan 2004 15:36:54 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.4.239) by sources.redhat.com with SMTP; 17 Jan 2004 15:36:54 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id CFB962B8F; Sat, 17 Jan 2004 10:36:51 -0500 (EST) Message-ID: <40095693.90007@gnu.org> Date: Sat, 17 Jan 2004 15:36:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Give decr pc after break a default of zero References: <40071B7A.3080106@gnu.org> <200401161623.i0GGNsEF000356@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00435.txt.bz2 > Removing the set-to-zero for Neutrino would be wrong; it is essential > that we override the i386 default. Personally I think the "NOTE" form > of the comment you added isn't really appropriate. I'd prefer > something like: > > /* Neutrino rewinds to look more normal, so we have to override the > i386 default value. */ > > Since that explains why we override the i386 default value. It's > probably a matter of taste, but I'd appreciate if you changes it that > way. I've changed it to: ``Neutrino rewinds to look more normal. Need to override the i386 default which is [unfortunatly] to decrement the PC.'' Make's it clear which is "wrong" :-) committed, Andrew