Re: RFA/ARM: Switch mode when setting PC

Daniel Jacobowitz
2004-01-16T17:32:37Z

On Fri, Jan 16, 2004 at 09:10:40AM -0500, Daniel Jacobowitz wrote:
> > The ari contains this yellow card:
> >
> > write pc
> > Replace write_pc() with get_frame_base_address or get_frame_id; at
> > present the inferior function call code still uses this when doing a
> > DECR_PC_AFTER_BREAK
> >
> > the concern is with the way write_pc is being called to perform two
> > different operations:
> >
> > - decrement the pc just after the target stops
> > Arrrg!
> > - jump to a specific address
> > As with an inferior function call or jump.
> >
> > I think it would be better to have two methods so that it's clear that
> > this case only applies when doing a jump.
>
> Well, it'd be better to rip out the current DECR_PC_AFTER_BREAK and
> handle it completely within the four (roughly) affected targets,
> thereby removing the overloading of write_pc. IMVHO.

Hi Andrew,

Is this patch OK (write_pc isn't deprecated yet!)? Cleaning up the
existing DECR_PC_AFTER_BREAK handling is going to be a touchy job, and
I don't really want to try it today :) I'll try to look into it later,
though.

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer