From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9155 invoked by alias); 11 Jan 2004 21:12:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9143 invoked from network); 11 Jan 2004 21:12:37 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.3.48) by sources.redhat.com with SMTP; 11 Jan 2004 21:12:37 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C4BEB2B8F; Sun, 11 Jan 2004 16:12:34 -0500 (EST) Message-ID: <4001BC42.8030207@gnu.org> Date: Sun, 11 Jan 2004 21:12:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Activate extract_struct_value_address for SPARC and UltraSPARC References: <200401112048.i0BKm0rv004191@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00297.txt.bz2 > Andrews -Wunused-function message pointed out that this wasn't hooked > up. So some of my previous patches were absolutely useless. Anyway, > this corrects the problem, and hooks things up. No regressions in > structs.exp on NetBSD/sparc and FreeBSD/sparc64. Um, > + set_gdbarch_extract_struct_value_address > + (gdbarch, sparc32_extract_struct_value_address); Is this one ever called? > +/* Extract from REGCACHE, which contains the (raw) register state, the > + address in which a function should return its structure value, as a > + CORE_ADDR. */ > + > +static CORE_ADDR > +sparc64_extract_struct_value_address (struct regcache *regcache) > +{ > + ULONGEST addr; > + > + regcache_cooked_read_unsigned (regcache, SPARC_O0_REGNUM, &addr); > + return addr; > +} and does this work reliably? Andrew