From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31859 invoked by alias); 15 Jul 2002 16:18:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31852 invoked from network); 15 Jul 2002 16:18:43 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.250) by sources.redhat.com with SMTP; 15 Jul 2002 16:18:43 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (Postfix) with ESMTP id 7F6965F1 for ; Mon, 15 Jul 2002 18:20:00 +0200 (CEST) Message-Id: <4.2.0.58.20020715174048.02a55688@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Mon, 15 Jul 2002 09:31:00 -0000 To: gdb-patches@sources.redhat.com From: Pierre Muller Subject: [RFC/RFA] avoid spurious Watchpoint X output on cygwin native target. Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2002-07/txt/msg00324.txt.bz2 The following patch suppresses all spurious output when a DLL is loaded in native cygwin GDB. Its a RFC for two reasons: First reason: Question: Why do we currently get ouptut while loading a DLL while the safe_symbol_file_add does redefine gdb_stdout and gdbstderr to dummy output exactly to suppress all output? Answer: Because, despite gdb_stdout is redefined as a dummy file does noting with the strings it gets (and thus is a correct way of suppressing ouptut sent to gdb_stdout), the Watchpoint X... message is sent to uiout struct (see mention function in breakpoint.c source) The only question here is if a change of gdb_stdout should not also change the global uiout variable behavior. This could easily be achieved by replacing the stream field of the data field of ui_out struct into a '** ui_file' instead of a simple '*ui_file'. Is that complete nonsense, or does it seem logical to someone? (One argument for this is that you get the same unwanted output on loading of shared libraries on linux for instance ...) Here is the win32 specific patch and the associated changelog. 2nd reason: It does not free the uiout struct created because I didn't find how to free this cleanly. 200-07-15 Pierre Muller * win32-nat.c: avoid unwanted ouptput about watchpoints on DLL loadings. (struct safe_symbol_file_add_args): New field uiout to store previous value of global uiout variable. (safe_symbol_file_add_cleanup): restore uiout value. (safe_symbol_file_add): store uiout and create a dummy one. $ cvs diff -u -p win32-nat.c Index: win32-nat.c =================================================================== RCS file: /cvs/src/src/gdb/win32-nat.c,v retrieving revision 1.60 diff -u -p -r1.60 win32-nat.c --- win32-nat.c 11 Jul 2002 13:50:49 -0000 1.60 +++ win32-nat.c 15 Jul 2002 16:10:42 -0000 @@ -45,6 +45,9 @@ #include #include + +#include "ui-out.h" +#include "cli-out.h" #include "buildsym.h" #include "symfile.h" #include "objfiles.h" @@ -494,6 +497,7 @@ struct safe_symbol_file_add_args int mainline; int flags; struct ui_file *err, *out; + struct ui_out *uiout; struct objfile *ret; }; @@ -534,6 +538,7 @@ safe_symbol_file_add_cleanup (void *p) ui_file_delete (gdb_stdout); gdb_stderr = sp->err; gdb_stdout = sp->out; + uiout = sp->uiout; #undef sp } @@ -550,10 +555,12 @@ safe_symbol_file_add (char *name, int fr p.err = gdb_stderr; p.out = gdb_stdout; + p.uiout = uiout; gdb_flush (gdb_stderr); gdb_flush (gdb_stdout); gdb_stderr = ui_file_new (); gdb_stdout = ui_file_new (); + uiout = cli_out_new (gdb_stdout); p.name = name; p.from_tty = from_tty; p.addrs = addrs; Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99